It contained Python-2--isms that caused errors when /usr/bin/python is Python 3
(at least on Fedora 32 with python-unversioned-command-3.8.2-2.fc32.noarch and
python3-3.8.2-2.fc32.x86_64):
> File "helpcontent2/helpers/make_icon_link.txt.py", line 21
> print "There was an error reading", file_icon
> ^
> SyntaxError: Missing parentheses in call to 'print'. Did you mean print("There was an error reading", file_icon)?
and
> File "helpcontent2/helpers/make_icon_link.txt.py", line 39
> if line.find('png',0, len(line)) <> -1 :
> ^
> SyntaxError: invalid syntax
So fix helpers/make_icon_link.txt.py to be proper Python 3 and explicitly
execute it with gb_ExternalExecutable_get_command,python instead of via a
/usr/bin/python shebang.
(That file was apparently not executed during the build prior to
ee180ade07e36dd1fb8c7bdca6ecbab44ded9eb8 "tdf#128519 Automate icon repl't table
for Help bld", so these issues were not noticied earlier.)
Change-Id: Ia3cff9538ab537076a02b64ad8c1bf56dcfaf30b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94039
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The solution here is to create links.txt.xsl in the
helpcontent2/helpers/ folder at build time because the <include>
directive in XSLT of online_transform.xsl must be hardcoded
(compile time) and core/workdir/ is not.
Change-Id: I8c4c8d0b8aed58c10a95c5d42bbd1b8acdb39614
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93436
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
The helper transforms XHP paragraphs into :
roles=note, warning, tip into <note>,<warning> and <tip>
roles=heading and level=[n] into <h[n]>
usage:
xsltproc refactor.xsl source.xhp > target.xhp
Change-Id: Ib3d69aebc35978f6e73a27bee232864bfe6e8463
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89832
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Changed to allow translation of filter names and media types
Removed randomness for paragraph ids to spare retranslation
Change-Id: If73d4799537b2d91ec9fe58584033b46eeeb9e04
Reviewed-on: https://gerrit.libreoffice.org/70671
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
command line --convert-to option miss description of the internal
names of the filters.
The xhp file is generated by the python script based on the
filter xcd's.
P2:
fix typo,
Fix <filename>,
Put modules in upercase.
P3:
reduce L10n workload with <embedvar>
P4:
Make xmllint happy again
Change-Id: I455491b1f6a141688308d768b2822f051566ae53
Reviewed-on: https://gerrit.libreoffice.org/70273
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
WIP. This is the Help part.
Extend the XML parser to include new incantations of the <paragraph>
tag, namely
<h1> to <h6>
<note>, <tip> and <warning>
Extension to the <item> tag:
<menuitem>, <input>, <literal>, <widget> and <keycode>
* removed test files
Change-Id: I2a473ee8772606f5e84bb02e651bccc6749598f4
Reviewed-on: https://gerrit.libreoffice.org/63954
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Such may appear if images are moved around in the
icon theme directories or between the icon themes
and the helpcontent2 repo.
Simple typos are also possible.
Change-Id: Iafee73efe9776ebf8ae74919c90644570593d94e
Reviewed-on: https://gerrit.libreoffice.org/32264
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
This script looks up <embed ...> tags in helpcontent, checks whether the
referenced file and id exist, and prints a warning if either one does not.
Execute from the root directory of the helpcontent2 repository.
No parameters are used.
Change-Id: Ic20bcfb1db398067231141b9af69c45590e1d452
Reviewed-on: https://gerrit.libreoffice.org/29732
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
it was introduced with d06c698b799e0e4ceaf3a3760c9589fe29dc29a9 on core
to have LO apply syntax-highlighting for Basic (for 4.1.0)
Change-Id: Ifbe4b511cad8810b2ebd179fb62097bcd22a556a
Reviewed-on: https://gerrit.libreoffice.org/21793
Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
