Commit Graph

256 Commits

Author SHA1 Message Date
17a565a57a Update icon replacement table for Help
Change-Id: I8295bda6fcb041811b73186a6a64346f4d374ea7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90574
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-17 21:15:02 +01:00
996909e807 Helponline: Make that image shadow look not tacky
Change-Id: I7e0b370ad883e787a8c7b7970d8d96653e577f8e
2020-03-12 13:09:19 -06:00
7fdef29282 Reorganise and refactor stuff in help.js for readability
Change-Id: Ife1b412350be5ac046736312ff9216273eff281b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89973
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-05 13:12:37 +01:00
3c28b5afd1 Fix links in xapian results page
Contents, Bookmarks and Modules links of xapian results pages
were broken after I486cbfbd680d52d00ef99ade9af5ecac2967c115

Change-Id: I7b912d9ff842810a66846b6a6da7857db69cac01
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89598
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-27 00:28:14 +01:00
d0bf3b122d Refactor XSLTs and CSS (2)
class -> id

Change-Id: I62c1af5a0203bb66fdd291dbf55633cbb3731353
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89207
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-22 13:12:58 +01:00
f48d72b4a8 Refactor XSLTs and CSS
more meanigful names

Change-Id: Ib786d2814adaed336f495992711eb89f99d85d39
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89206
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-22 13:12:28 +01:00
197930c8b9 Remove very old unused CSS
Change-Id: I8af3443fb8db832ac2fc9a88dfb6fd779d3475ed
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89163
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-21 12:40:58 +01:00
7f5456a742 Update icon replacement table
Change-Id: Id73f42124c4a5b08fedeaa28cf26043a03f52cfe
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88886
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-17 23:13:11 +01:00
96f1ee8417 Don't hardcode version in links in online help
... so that when current page URL is like

https://help.libreoffice.org/latest/en-US/text/shared/05/new_help.html

links from it will lead to other pages under 'latest', not to

https://help.libreoffice.org/6.3/...

The problem reason was that in online help, HTML referred to resources
with relative URLs starting with version number, like
'href="6.3/media/navigation/favicon.ico"'. The links didn't include the
version level in local help: 'href="media/navigation/favicon.ico"'.
This was naturally accompanied by <base href="../../../../../"> (online)
and '<base href="../../../../">' (local), coming from "tokenize" in
help3xsl/online_transform.xsl.

This unifies online help behaviour with that of local help.

Change-Id: I486cbfbd680d52d00ef99ade9af5ecac2967c115
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87768
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-10 02:34:34 +01:00
35281f4c91 tdf#127566: don't change divcopyable border width in onclick handler
Instead, define border width in respective CSS, to make it consistent
in both clicked and non-clicked states, and avoid "jumping" on click.

Change-Id: Ic8ab8d0fd586059e21de6aa866fef95226774acf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87718
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-30 11:21:57 +01:00
3e3457dd21 Update Colibre icons replacement table in Help.
Change-Id: Ieab4b0822462b2d6883a90dfd9061cfa6870ddce
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87602
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-28 13:09:22 +01:00
8181441922 Update icon repplacement table (Colibre)
Also, replace all ref of .png to .svg

Change-Id: Ib2c9d0281cb5bfe3e016f69f2879d2fc90f08181
Reviewed-on: https://gerrit.libreoffice.org/84934
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-11 11:57:06 +01:00
2831667e5e Update list of missing icons for Help
Change-Id: I1a5b28ddb0e057c83a1da88b8b9337a0479a217d
Reviewed-on: https://gerrit.libreoffice.org/84658
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-06 17:21:52 +01:00
759f363668 Fix div position for Online Help
The condition was masking the div.
Now the condition mask the contents

Change-Id: I270e20f3ae17a16d4425698f24e674763320fade
Reviewed-on: https://gerrit.libreoffice.org/83540
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-23 01:00:29 +01:00
d034a998ce Fix switch selection when embedded in other pages
Emebed exerpts with switch tags were unable to perform
the correct switch because of the use of the same id= in
several places in the page. The new logic fixes that.

Change-Id: I1e1084170e023c89f3c695c3d1c5a6c7deee7374
Reviewed-on: https://gerrit.libreoffice.org/82277
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-08 19:42:27 +01:00
19c60db20e Fix missing %PRODUCTNAME replacements
Some contents were still carrying %PRODUCTNAME variable
Apply template brand on
<bascode>,
<meta itemprop../> and
<title>

Change-Id: Ia93204cba63ba72d1df6014e3de37d7322c68029
Reviewed-on: https://gerrit.libreoffice.org/82256
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-08 01:18:45 +01:00
aa590ae9d2 Add stemmer info in omindex search
Change-Id: I3e899f4e31d15ea332e6b69d14218d1e8e364c7f
Reviewed-on: https://gerrit.libreoffice.org/81924
Tested-by: Jenkins
Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org>
Tested-by: Guilhem Moulin <guilhem@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-03 00:38:55 +01:00
ce502938b6 Update icon replacement table in XSLT
Change-Id: Idc7b98d02f07b9d47429fca1330021fee044971a
Reviewed-on: https://gerrit.libreoffice.org/81811
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-31 01:21:20 +01:00
fdc5abfc53 Give some space around images
Change-Id: Ic7251bfa74c9ee1ac8b55edf8f6bed9791d42903
Reviewed-on: https://gerrit.libreoffice.org/81442
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-24 13:22:03 +02:00
0dc045bd9c Add Option View help page screenshot
+ tweak CSS for images

Change-Id: Iaa304a0ccecb6cdea2421de4ffaed52d71a0c76b
Reviewed-on: https://gerrit.libreoffice.org/81287
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-22 16:28:15 +02:00
5eb66f297b Update icon replacement table
Change-Id: I4a83337dea81a6bda5d464a305e02ad65ee5a97d
Reviewed-on: https://gerrit.libreoffice.org/81159
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20 14:40:22 +02:00
7ba76b180f Fix <br/> when embedded
Change-Id: I8cfc619adc68718b261d9f661531886789a872ac
Reviewed-on: https://gerrit.libreoffice.org/80992
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-18 11:44:26 +02:00
242a6bbefc More work on Xapian result page
Added module dropdown fix
TODO: Language

Change-Id: I47012d6280694d87fb5d19e25c6052b8a7ed89c7
Reviewed-on: https://gerrit.libreoffice.org/80771
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-14 21:13:15 +02:00
404ff19a22 Fix top row of page grid
Change-Id: I9ae465ac9d00df5561157e0872217a1e8a09e159
Reviewed-on: https://gerrit.libreoffice.org/80678
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-11 20:06:25 +02:00
2e077c0f9f Fix xapian search bar in Help online (WIP)
Change-Id: Ibe178ff79a27b8a21fcbaf2465c66da0786a28fd
WIP: need adjusts for mobile.
Reviewed-on: https://gerrit.libreoffice.org/80605
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-11 13:01:44 +02:00
aa45ded698 redmine#2555 replace Help online Google search
This is the helpcontent2/ part of the patch.

Add xapian-omega search to online Help.

The patch replaces Google custom search with xapian-omega search.

A new build key is introduced.

--with-omindex=server : Localizes and adds the xapian result page
template, adds the xapian form to each Help page.

--with-omindex=noxap : do not localize the result template and
do not add a form in the Help page.

--with-omindex= will force Online Help build.

Default is noxap

NOTES:
- xapian-omega databases are built in the server.
- searches returns results only on localized Help pages, avoiding same
resulis in many languages.

TODO:
- Tweak the xapian-omega result page CSS and markup.

Change-Id: I3dc2b79c4111f61fd5fea01b1f8c95bfacab1e8f
Reviewed-on: https://gerrit.libreoffice.org/79366
Tested-by: Jenkins
Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org>
Tested-by: Guilhem Moulin <guilhem@libreoffice.org>
2019-10-01 15:00:44 +02:00
221fbbf7f1 Update missing icons list in Help
Change-Id: I5b62a64e00def6ab38d8ae0526133f456090b256
Reviewed-on: https://gerrit.libreoffice.org/76906
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-05 14:59:49 +02:00
5eca0aaa7f Update list of replacement icons in master
Change-Id: I3da2cac812591bf1a0eed69c4a8746592e9042e3
Reviewed-on: https://gerrit.libreoffice.org/72969
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-26 01:57:35 +02:00
085cd2e40a Hide our nav checkbox inputs only visually
Some screenreaders do not read elements with opacity: 0

Change-Id: Ifc4c97a58c87e7d6b9533e15dc0db60aa70bfb97
Reviewed-on: https://gerrit.libreoffice.org/72519
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-18 16:53:19 +02:00
301ae74e8b Improve accessibility for modules and lang menus
Ever since the contents of the modules and lang menus started
being populated upon click, the flow for screenreader users has
been potentially confusing.

This patch introduces a11y-toggle into the mix:
https://github.com/edenspiekermann/a11y-toggle
Checkboxes were changed into buttons. This hopefully makes it
clear we want the user to click them.

The contents tree still uses the checkbox hack, because its items
are populated upon page load.

Change-Id: I3482bea0c8669f96794498fc37d9d18fe3f829d5
Reviewed-on: https://gerrit.libreoffice.org/72467
Tested-by: Jenkins
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-18 13:34:26 +02:00
578f74466f tdf#122366 Store search filter value in sessionStorage
sessionStorage seems to be reset, when we change the module context.
If this is not acceptable, we can try localStorage.

Change-Id: I5ec2ff526e48dd2c7d1889578e991833e43f76c6
Reviewed-on: https://gerrit.libreoffice.org/71688
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-02 20:17:50 +02:00
de68dd22d4 Limit the scope of getting class names for index titles
Change-Id: I2d586605118032aaf38ff70d420bc7c2bf4979ae
Reviewed-on: https://gerrit.libreoffice.org/71529
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-29 16:54:06 +02:00
3c494b6e6d tdf#122548 copy bascode and pycode to clipboard
This will allow easy testing of coding examples.

Change-Id: I30fc53642b1579744591f2de0c84a615d1755352
Reviewed-on: https://gerrit.libreoffice.org/71385
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-26 20:46:16 +02:00
2d21ebb74b Revert "Create XSLT replacement table for missing icons"
This reverts commit 61f44912beec99f6211399ce567274aa369f817d.

Change-Id: Icd69ccd4f487a82426a00169728ec62bbff6d0b6
Reviewed-on: https://gerrit.libreoffice.org/70350
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-06 21:52:57 +02:00
61f44912be Create XSLT replacement table for missing icons
Missing UI icons have a replacement table in
/core/icon-themes/colibre/links.txt

Help must also use this replacement table when Help
pages have missing icons. The previous approach was a manual
creation of a XSLT for the replacement.

The patch moves the replacement table creation inside the
Custom makefile, making it automatic and carrying changes
of the original links.txt source.

Change-Id: I7f834fa03bbd85f329efbec43e5c51cc86d51586
Reviewed-on: https://gerrit.libreoffice.org/70080
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-06 16:04:33 +02:00
06d97c85e4 Fix typo
Change-Id: I064146b36884740fc90b889ea92758a10782b5dd
Reviewed-on: https://gerrit.libreoffice.org/69823
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-27 15:41:30 +01:00
ca2a6bf2c3 tdf#124245 Polyfills and fixes for IE11
The polyfills can be removed after we drop IE11 support.

Other IE11 fixes:

Change from document.URL to window.location.pathname
because otherwise we get local Windows paths with backward
slashes.

Use clear: left; for google-donation element so it doesn't
float on top of other elements.

Don't use defer to load fuzzysort.js and prism.js.

Change-Id: I6c0143eab555c8b1fbdbde8e749a24baed2f69c8
Reviewed-on: https://gerrit.libreoffice.org/69549
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-27 09:42:01 +01:00
9b776454d9 Add module name to Contents link URL
Add ?DbPAR=<MODULE> to the contents link URL. <smodule>.tree does not
have the DbPAR param in the link URLs.

2 possibiltites:
1) Add to the source files *.tree and we are done (triggers retranslation)

2) get module name at build time and add to the resulting tree (this
solution)

Change-Id: I2a3c1edcec7dd824a44bb93f0343ec8cb88cb0c4
Reviewed-on: https://gerrit.libreoffice.org/69714
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-26 12:51:58 +01:00
34aca15b8c Header and donation CSS tweaks
Change-Id: I20e5610c08db700e12baffa9b62dcf8dfd0c4328
Reviewed-on: https://gerrit.libreoffice.org/69278
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
2019-03-15 00:34:21 +01:00
3d0fcf7a37 New approach to switch cases
My previous JS patch broke the sys and appl switch behaviour.

This patch removes the inline function calls from
online_transform.xsl. Instead, help2.js now finds the relevant spans
and calls the functions for them.

Change-Id: I45d5b75bdb70a7c18eaa0b215beb57e3e1b6719a
Reviewed-on: https://gerrit.libreoffice.org/69137
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-13 20:11:32 +01:00
54e3236790 Show module & lang navigation on mobile
Module & languages menus were not shown on screen widths < 960.

Changed module & languages menu background to span the whole
width, when on mobile.

An arrow function was used in help2.js, which means it was broken
on IE.

Moved all src .js files to head and used defer for all.

Moved inline Piwik & system info JS into help2.js and added a
test for onlineness targeting the first meta element in the body.

Change-Id: Ic1a928b53ce9029f9f655117977cd511b7e3246d
Reviewed-on: https://gerrit.libreoffice.org/69005
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-10 19:22:22 +01:00
3013fcc8dd tdf#53524 (compl) Minor tweaks in Help page.
Added ref to icons
minor updates on tags

Change-Id: Ia9812a5928554284a5a2fb5416983888e2437439
Reviewed-on: https://gerrit.libreoffice.org/68915
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-08 12:44:35 +01:00
eb2972e06b Donation button and sticky header for Help
Task: https://redmine.documentfoundation.org/issues/2815

Header was made sticky on non-mobile by using position: sticky.
This was the only way to make it work with the grid without
carving magic numbers into stone. IE11 ignores it, but so what?

Donation text was made shorter.

The Google search and the donation button were wrapped in a
container to make it easy to haul them all over the place.

Lots of tweaks were made to the grid areas and the styles of
the bottom elements to make everything fit nicely in the new
markup order. The result was tested on IE11 to make sure it
degrades gracefully.

The Displayarea element had a fixed width (my old mistake),
which made the min-width: 960px layout look very uncool.

Change-Id: I131a1e82290bc3381c938acb4dc9dbc408fb2ba7
Reviewed-on: https://gerrit.libreoffice.org/68890
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-08 11:48:40 +01:00
4f35fbbb29 Revert "Improve donation link in Help online"
This reverts commit bd26e706b30dccecdeba24ba8b697ddf2fc7a615.

Change-Id: Id45b4ef2bacae444be070a03fbc0e10a4992f85c
Reviewed-on: https://gerrit.libreoffice.org/68699
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-04 15:46:21 +01:00
fd16b597ba Some optimizing bits in XSLT
Change-Id: I27c29677cbf9c704d64b5ed49acc56b7a22432bd
Reviewed-on: https://gerrit.libreoffice.org/68646
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-04 15:42:18 +01:00
bd26e706b3 Improve donation link in Help online
redmine#2815

Addressed responsiveness: for screen width < 960px the
button goes to the bottom of the screen and the header is
not fixed anymore.

Artists are invited to improve button rendering.

Button max width is 300px, the en-US text and the translated
text should fit in 2 lines of 300px each. Text is centered.

Change-Id: I51860be2ad998e85f247118e44b21af3e2efa060
Reviewed-on: https://gerrit.libreoffice.org/68644
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-03-04 15:41:52 +01:00
3b685b8086 Update list of missin icon replacements
Change-Id: I193c10fa8c75f61fbcd749284f81e69f5f4ad603
Reviewed-on: https://gerrit.libreoffice.org/68464
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-27 21:56:39 +01:00
040dcfa774 Update Colibre icon replacement table in Help
Change-Id: Ie3e2fbca2f74d47a90e43c1707c28df46b7cf1ec
Reviewed-on: https://gerrit.libreoffice.org/68208
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-23 16:44:20 +01:00
ec242a0c85 More CSS tweaks…
• Ever-so-slightly brightened link color
• Made most tables centered; I think they look much better
• Removed some pointless spacing
• Made all dropdown options consistently align to the left
• Finally found out why pagination had extra 40px to its left
  and it’s a shame the normalizer doesn’t account for it
• Correctly made disabled pagination links unsensitive
• Gave styling to the search bar for consistent appearance
  in Gecko- and Blink-based browsers

Change-Id: Idcb488160aa97ec0c4adb5202aed7f194dfac7c9
2019-02-21 06:48:09 -06:00
54a17bfbc7 Fix call of main Help page from app Help menu
The Application Help menu sends /<module>/.uno:HelpIndex in the Help
URL.

This translates to '.uno:HelpIndex' and module name is lost, opening the
New Help default page instead of the module Help entry page.

The patch picks the right module Help entry page in this particular
case.

Change-Id: Ifbb5ba4f817b195210fbb19bcb5c2011d2cb416d
Reviewed-on: https://gerrit.libreoffice.org/68093
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-20 18:23:05 +01:00