database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[test](nereids)add fe ut for SimplifyArithmeticComparisonRule (#27644)

Browse Source
This commit is contained in:
starocean999
2024-01-29 15:26:37 +08:00
committed by yiguolei
parent 3b85e3de1b
commit 036e17dcb0
2 changed files with 46 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyArithmeticComparisonRule.java
View File

@ -82,20 +82,23 @@ public class SimplifyArithmeticComparisonRule extends AbstractExpressionRewriteR
@Override
public Expression visitComparisonPredicate(ComparisonPredicate comparison, ExpressionRewriteContext context) {
ComparisonPredicate newComparison = comparison;
if (couldRearrange(comparison)) {
newComparison = normalize(comparison);
ComparisonPredicate newComparison = normalize(comparison);
if (newComparison == null) {
return comparison;
}
try {
List<Expression> children = tryRearrangeChildren(newComparison.left(), newComparison.right());
newComparison = (ComparisonPredicate) newComparison.withChildren(children);
List<Expression> children =
tryRearrangeChildren(newComparison.left(), newComparison.right(), context);
newComparison = (ComparisonPredicate) visitComparisonPredicate(
(ComparisonPredicate) newComparison.withChildren(children), context);
} catch (Exception e) {
return comparison;
}
return TypeCoercionUtils.processComparisonPredicate(newComparison);
} else {
return comparison;
}
return TypeCoercionUtils.processComparisonPredicate(newComparison);
}
private boolean couldRearrange(ComparisonPredicate cmp) {
@ -104,11 +107,12 @@ public class SimplifyArithmeticComparisonRule extends AbstractExpressionRewriteR
&& cmp.left().children().stream().anyMatch(Expression::isConstant);
}
private List<Expression> tryRearrangeChildren(Expression left, Expression right) throws Exception {
if (!left.child(1).isLiteral()) {
private List<Expression> tryRearrangeChildren(Expression left, Expression right,
ExpressionRewriteContext context) throws Exception {
if (!left.child(1).isConstant()) {
throw new RuntimeException(String.format("Expected literal when arranging children for Expr %s", left));
}
Literal leftLiteral = (Literal) left.child(1);
Literal leftLiteral = (Literal) FoldConstantRule.INSTANCE.rewrite(left.child(1), context);
Expression leftExpr = left.child(0);
Class<? extends Expression> oppositeOperator = rearrangementMap.get(left.getClass());