database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[opt](catalog) cache the converted properties (#30668)

Browse Source 
convert properties may be a heavy operation, so we cache the result.
This commit is contained in:
Mingyu Chen
2024-02-05 22:43:33 +08:00
committed by yiguolei
parent cde74cbfee
commit 06ed5780e4
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java
View File

@ -104,6 +104,10 @@ public abstract class ExternalCatalog
private ExternalSchemaCache schemaCache;
private String comment;
// A cached and being converted properties for external catalog.
// generated from catalog properties.
private byte[] propLock = new byte[0];
private Map<String, String> convertedProperties = null;
public ExternalCatalog() {
}
@ -298,6 +302,9 @@ public abstract class ExternalCatalog
public void onRefresh(boolean invalidCache) {
this.objectCreated = false;
this.initialized = false;
synchronized (this.propLock) {
this.convertedProperties = null;
}
this.invalidCacheInInit = invalidCache;
if (invalidCache) {
Env.getCurrentEnv().getExtMetaCacheMgr().invalidateCatalogCache(id);
@ -421,7 +428,17 @@ public abstract class ExternalCatalog
@Override
public Map<String, String> getProperties() {
return PropertyConverter.convertToMetaProperties(catalogProperty.getProperties());
// convert properties may be a heavy operation, so we cache the result.
if (convertedProperties != null) {
return convertedProperties;
}
synchronized (propLock) {
if (convertedProperties != null) {
return convertedProperties;
}
convertedProperties = PropertyConverter.convertToMetaProperties(catalogProperty.getProperties());
return convertedProperties;
}
}
@Override
@ -552,6 +569,7 @@ public abstract class ExternalCatalog
}
}
}
this.propLock = new byte[0];
}
public void addDatabaseForTest(ExternalDatabase<? extends ExternalTable> db) {