database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Add max cache size to ClientCache in BE (#1202)

Browse Source 
Currently, unlimited client cache pool may cause too many connections in FE
This commit is contained in:
Mingyu Chen
2019-05-24 22:02:09 +08:00
committed by ZHAO Chun
parent 41152f5c84
commit 08c8caeacf
6 changed files with 58 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
be/src/runtime/client_cache.cpp
View File

@ -135,15 +135,24 @@ Status ClientCacheHelper::create_client(
void ClientCacheHelper::release_client(void** client_key) {
DCHECK(*client_key != NULL) << "Trying to release NULL client";
boost::lock_guard<boost::mutex> lock(_lock);
ClientMap::iterator i = _client_map.find(*client_key);
DCHECK(i != _client_map.end());
ThriftClientImpl* info = i->second;
//VLOG_RPC << "releasing client for "
// << info->ipaddress() << ":" << info->port();
ClientCacheMap::iterator j =
_client_cache.find(make_network_address(info->ipaddress(), info->port()));
ClientMap::iterator client_map_entry = _client_map.find(*client_key);
DCHECK(client_map_entry != _client_map.end());
ThriftClientImpl* info = client_map_entry->second;
ClientCacheMap::iterator j = _client_cache.find(make_network_address(info->ipaddress(), info->port()));
DCHECK(j != _client_cache.end());
j->second.push_back(*client_key);
if (_max_cache_size_per_host >=0 && j->second.size() >= _max_cache_size_per_host) {
// cache of this host is full, close this client connection and remove if from _client_map
info->close();
_client_map.erase(*client_key);
delete info;
if (_metrics_enabled) {
_opened_clients->increment(-1);
}
} else {
j->second.push_back(*client_key);
}
if (_metrics_enabled) {
_used_clients->increment(-1);
@ -165,7 +174,10 @@ void ClientCacheHelper::close_connections(const TNetworkAddress& hostport) {
BOOST_FOREACH(void * client_key, cache_entry->second) {
ClientMap::iterator client_map_entry = _client_map.find(client_key);
DCHECK(client_map_entry != _client_map.end());
client_map_entry->second->close();
ThriftClientImpl* info = client_map_entry->second;
info->close();
_client_map.erase(client_key);
delete info;
}
}