diff --git a/be/src/runtime/runtime_predicate.cpp b/be/src/runtime/runtime_predicate.cpp index a16984ae70..627e22364e 100644 --- a/be/src/runtime/runtime_predicate.cpp +++ b/be/src/runtime/runtime_predicate.cpp @@ -135,11 +135,6 @@ Status RuntimePredicate::update(const Field& value, const String& col_name, bool std::unique_lock wlock(_rwlock); - // TODO why null - if (!_tablet_schema) { - return Status::OK(); - } - bool updated = false; if (UNLIKELY(_orderby_extrem.is_null())) { @@ -161,6 +156,10 @@ Status RuntimePredicate::update(const Field& value, const String& col_name, bool return Status::OK(); } + // TODO defensive code + if (!_tablet_schema || !_tablet_schema->have_column(col_name)) { + return Status::OK(); + } // update _predictate int32_t col_unique_id = _tablet_schema->column(col_name).unique_id(); const TabletColumn& column = _tablet_schema->column_by_uid(col_unique_id); diff --git a/be/src/runtime/runtime_predicate.h b/be/src/runtime/runtime_predicate.h index b1d4dadf1a..9607bf37ef 100644 --- a/be/src/runtime/runtime_predicate.h +++ b/be/src/runtime/runtime_predicate.h @@ -66,8 +66,8 @@ private: mutable std::shared_mutex _rwlock; Field _orderby_extrem {Field::Types::Null}; std::shared_ptr _predictate {nullptr}; - TabletSchemaSPtr _tablet_schema; - std::unique_ptr _predicate_arena; + TabletSchemaSPtr _tablet_schema {nullptr}; + std::unique_ptr _predicate_arena {nullptr}; std::function _get_value_fn; bool _nulls_first = true; bool _inited = false;