database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[bug](distinct agg) fix distinct streaming agg not output all data (#32760)

Browse Source 
fix distinct streaming agg not output all data
This commit is contained in:
zhangstar333
2024-03-26 17:34:19 +08:00
committed by yiguolei
parent ad2d20348a
commit 0a44de67bf
5 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
be/src/vec/exec/distinct_vaggregation_node.cpp
View File

@ -17,8 +17,11 @@
#include "vec/exec/distinct_vaggregation_node.h"
#include <glog/logging.h>
#include "runtime/runtime_state.h"
#include "vec/aggregate_functions/aggregate_function_uniq.h"
#include "vec/columns/column.h"
#include "vec/exec/vaggregation_node.h"
namespace doris {
@ -64,9 +67,18 @@ Status DistinctAggregationNode::_distinct_pre_agg_with_serialized_key(
SCOPED_TIMER(_insert_keys_to_column_timer);
bool mem_reuse = _make_nullable_keys.empty() && out_block->mem_reuse();
if (mem_reuse) {
if (_stop_emplace_flag && !out_block->empty()) {
// when out_block row >= batch_size, push it to data_queue, so when _stop_emplace_flag = true, maybe have some data in block
// need output those data firstly
for (int i = 0; i < rows; ++i) {
_distinct_row.push_back(i);
}
}
for (int i = 0; i < key_size; ++i) {
auto output_column = out_block->get_by_position(i).column;
if (_stop_emplace_flag) { // swap the column directly, to solve Check failed: d.column->use_count() == 1 (2 vs. 1)
if (_stop_emplace_flag && _distinct_row.empty()) {
// means it's streaming and out_block have no data.
// swap the column directly, so not insert data again. and solve Check failed: d.column->use_count() == 1 (2 vs. 1)
out_block->replace_by_position(i, key_columns[i]->assume_mutable());
in_block->replace_by_position(result_idxs[i], output_column);
} else {