database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Improvement](multi catalog)Add comment to external hms table show create table output. (#14861)

Browse Source 
The output of show create table comment for hms external table doesn't contain comment section.
This pr is to add the comment to the output.
This commit is contained in:
Jibing-Li
2022-12-07 21:12:30 +08:00
committed by GitHub
parent dfb02a7104
commit 0bc6f91c3a
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
fe/fe-core/src/main/java/org/apache/doris/catalog/HiveMetaStoreClientHelper.java
View File

@ -96,6 +96,7 @@ public class HiveMetaStoreClientHelper {
public static final String HIVE_METASTORE_URIS = "hive.metastore.uris";
public static final String HIVE_METASTORE_TYPE = "hive.metastore.type";
public static final String DLF_TYPE = "dlf";
public static final String COMMENT = "comment";
private static final Pattern digitPattern = Pattern.compile("(\\d+)");
@ -835,6 +836,9 @@ public class HiveMetaStoreClientHelper {
}
}
output.append(")\n");
if (remoteTable.getParameters().containsKey(COMMENT)) {
output.append(String.format("COMMENT '%s'", remoteTable.getParameters().get(COMMENT))).append("\n");
}
if (remoteTable.getPartitionKeys().size() > 0) {
output.append("PARTITIONED BY (\n")
.append(remoteTable.getPartitionKeys().stream().map(
@ -869,7 +873,15 @@ public class HiveMetaStoreClientHelper {
}
if (remoteTable.isSetParameters()) {
output.append("TBLPROPERTIES (\n");
Iterator<Map.Entry<String, String>> params = remoteTable.getParameters().entrySet().iterator();
Map<String, String> parameters = Maps.newHashMap();
// Copy the parameters to a new Map to keep them unchanged.
parameters.putAll(remoteTable.getParameters());
if (parameters.containsKey(COMMENT)) {
// Comment is always added to the end of remote table parameters.
// It has already showed above in COMMENT section, so remove it here.
parameters.remove(COMMENT);
}
Iterator<Map.Entry<String, String>> params = parameters.entrySet().iterator();
while (params.hasNext()) {
Map.Entry<String, String> param = params.next();
output.append(String.format(" '%s'='%s'", param.getKey(), param.getValue()));