From 0cc4ee52bf3dcc8cc6b928f14be8a4e3855623f5 Mon Sep 17 00:00:00 2001 From: Kaijie Chen Date: Wed, 27 Dec 2023 21:48:32 +0800 Subject: [PATCH] [fix](move-memtable) fix streams for node memory leak in sink v2 (#29146) --- be/src/vec/sink/writer/vtablet_writer_v2.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/vec/sink/writer/vtablet_writer_v2.cpp b/be/src/vec/sink/writer/vtablet_writer_v2.cpp index ae753c8714..f413c00dc0 100644 --- a/be/src/vec/sink/writer/vtablet_writer_v2.cpp +++ b/be/src/vec/sink/writer/vtablet_writer_v2.cpp @@ -502,6 +502,7 @@ Status VTabletWriterV2::close(Status exec_status) { for (const auto& [_, streams] : _streams_for_node) { streams->release(); } + _streams_for_node.clear(); }); { @@ -541,7 +542,6 @@ Status VTabletWriterV2::close(Status exec_status) { _state->tablet_commit_infos().insert(_state->tablet_commit_infos().end(), std::make_move_iterator(tablet_commit_infos.begin()), std::make_move_iterator(tablet_commit_infos.end())); - _streams_for_node.clear(); // _number_input_rows don't contain num_rows_load_filtered and num_rows_load_unselected in scan node int64_t num_rows_load_total = _number_input_rows + _state->num_rows_load_filtered() +