database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](nereids) UT failed when test cases in package (#12622)

Browse Source 
NamedExpressionUtil::clear should reset the nextId rather than create a new IdGenerator<ExprId> because the old one may be referenced by other objects and it may cause some cases start in a dirty environment when we run test cases in package.
This commit is contained in:
Adonis Ling
2022-09-15 22:25:40 +08:00
committed by GitHub
parent 3072e17b39
commit 0daa25d9a9
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/NamedExpressionUtil.java
View File

@ -22,7 +22,6 @@ import org.apache.doris.common.IdGenerator;
import com.google.common.annotations.VisibleForTesting;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
/**
* The util of named expression.
@ -42,11 +41,8 @@ public class NamedExpressionUtil {
*/
@VisibleForTesting
public static void clear() throws Exception {
Field f = NamedExpressionUtil.class.getDeclaredField("ID_GENERATOR");
f.setAccessible(true);
Field mf = Field.class.getDeclaredField("modifiers");
mf.setAccessible(true);
mf.setInt(f, f.getModifiers() & ~Modifier.FINAL);
f.set(NamedExpressionUtil.class, ExprId.createGenerator());
Field nextId = ID_GENERATOR.getClass().getSuperclass().getDeclaredField("nextId");
nextId.setAccessible(true);
nextId.setInt(ID_GENERATOR, 0);
}
}