diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java index e5848a745a..580e0799e9 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java @@ -706,14 +706,14 @@ public class OlapTable extends Table { nameToPartition.put(partition.getName(), partition); } - // This is a private methid. + // This is a private method. // Call public "dropPartitionAndReserveTablet" and "dropPartition" private Partition dropPartition(long dbId, String partitionName, boolean isForceDrop, boolean reserveTablets) { // 1. If "isForceDrop" is false, the partition will be added to the Catalog Recyle bin, and all tablets of this // partition will not be deleted. - // 2. If "ifForceDrop" is true, the partition will be dropped the immediately, but whether to drop the tablets + // 2. If "ifForceDrop" is true, the partition will be dropped immediately, but whether to drop the tablets // of this partition depends on "reserveTablets" - // If "reserveTablets" is true, the tablets of this partition will not to deleted. + // If "reserveTablets" is true, the tablets of this partition will not be deleted. // Otherwise, the tablets of this partition will be deleted immediately. Partition partition = nameToPartition.get(partitionName); if (partition != null) { @@ -741,7 +741,7 @@ public class OlapTable extends Table { try { dummyKey = PartitionKey.createInfinityPartitionKey(dummyColumns, false); } catch (AnalysisException e) { - e.printStackTrace(); + LOG.warn("should not happen", e); } Range dummyRange = Range.open(new PartitionKey(), dummyKey); diff --git a/fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java b/fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java index dde22e54d0..9b21c9479c 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java +++ b/fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java @@ -439,7 +439,7 @@ public class DynamicPartitionScheduler extends MasterDaemon { dropPartitionClauses = getDropPartitionClause(db, olapTable, partitionColumn, partitionFormat); tableName = olapTable.getName(); } catch (DdlException e) { - e.printStackTrace(); + LOG.warn("should not happen", e); } finally { olapTable.readUnlock(); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/GenericPool.java b/fe/fe-core/src/main/java/org/apache/doris/common/GenericPool.java index ee52f10577..86d381f27a 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/common/GenericPool.java +++ b/fe/fe-core/src/main/java/org/apache/doris/common/GenericPool.java @@ -119,7 +119,7 @@ public class GenericPool { try { pool.invalidateObject(address, object); } catch (Exception e) { - e.printStackTrace(); + LOG.warn("failed to invalidate object. address: {}", address.toString(), e); } } diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/util/SmallFileMgr.java b/fe/fe-core/src/main/java/org/apache/doris/common/util/SmallFileMgr.java index ee5150d2f1..7a1660798b 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/common/util/SmallFileMgr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/common/util/SmallFileMgr.java @@ -506,8 +506,7 @@ public class SmallFileMgr implements Writable { try { smallFiles.addFile(smallFile.name, smallFile); } catch (DdlException e) { - // should not happen - e.printStackTrace(); + LOG.warn("should not happen", e); } } } diff --git a/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java b/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java index 4cc39b5a18..fc84515fc0 100755 --- a/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java +++ b/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java @@ -138,7 +138,6 @@ public class FEFunctions { dateLiteral.setType(ScalarType.getDefaultDateType(dateLiteral.getType())); return dateLiteral; } catch (InvalidFormatException e) { - e.printStackTrace(); throw new AnalysisException(e.getMessage()); } }