From 121f00b6e2f24e53e9d1d21c403d8471d86796fe Mon Sep 17 00:00:00 2001 From: Pxl Date: Wed, 28 Dec 2022 12:23:34 +0800 Subject: [PATCH] [Bug](function) forbid hll_union input not hll type param (#15397) forbid hll_union input not hll type param --- .../org/apache/doris/analysis/FunctionCallExpr.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java index 287f7d2377..d28e66abe9 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java @@ -815,12 +815,13 @@ public class FunctionCallExpr extends Expr { } } - if ((fnName.getFunction().equalsIgnoreCase(FunctionSet.HLL_UNION_AGG) - || fnName.getFunction().equalsIgnoreCase(FunctionSet.HLL_CARDINALITY) - || fnName.getFunction().equalsIgnoreCase(FunctionSet.HLL_RAW_AGG)) + if ((fnName.getFunction().equalsIgnoreCase("HLL_UNION_AGG") + || fnName.getFunction().equalsIgnoreCase("HLL_CARDINALITY") + || fnName.getFunction().equalsIgnoreCase("HLL_RAW_AGG") + || fnName.getFunction().equalsIgnoreCase("HLL_UNION")) && !arg.type.isHllType()) { throw new AnalysisException( - "HLL_UNION_AGG, HLL_RAW_AGG and HLL_CARDINALITY's params must be hll column"); + "HLL_UNION, HLL_UNION_AGG, HLL_RAW_AGG and HLL_CARDINALITY's params must be hll column"); } if (fnName.getFunction().equalsIgnoreCase("min") @@ -829,7 +830,7 @@ public class FunctionCallExpr extends Expr { } else if (fnName.getFunction().equalsIgnoreCase("DISTINCT_PC") || fnName.getFunction().equalsIgnoreCase("DISTINCT_PCSA") || fnName.getFunction().equalsIgnoreCase("NDV") - || fnName.getFunction().equalsIgnoreCase(FunctionSet.HLL_UNION_AGG)) { + || fnName.getFunction().equalsIgnoreCase("HLL_UNION_AGG")) { fnParams.setIsDistinct(false); }