database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](covar) Fix covar nullable on branch-2.1 (#40841)

Browse Source 
covar should not be always nullable.

This fix on branch-2.1 makes covar same with master on FE.
This commit is contained in:
zhiqiang
2024-09-20 17:35:27 +08:00
committed by GitHub
parent 596cfc9b18
commit 1259fe2bd5
3 changed files with 48 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Covar.java
View File

@ -19,7 +19,6 @@ package org.apache.doris.nereids.trees.expressions.functions.agg;
import org.apache.doris.catalog.FunctionSignature;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.shape.UnaryExpression;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
@ -38,8 +37,8 @@ import java.util.List;
/**
* AggregateFunction 'covar'. This class is generated by GenerateFunction.
*/
public class Covar extends AggregateFunction
implements UnaryExpression, ExplicitlyCastableSignature, AlwaysNullable {
public class Covar extends NullableAggregateFunction
implements UnaryExpression, ExplicitlyCastableSignature {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE, DoubleType.INSTANCE),
@ -54,14 +53,18 @@ public class Covar extends AggregateFunction
* constructor with 2 argument.
*/
public Covar(Expression arg1, Expression arg2) {
super("covar", arg1, arg2);
this(false, arg1, arg2);
}
/**
* constructor with 3 arguments.
*/
public Covar(boolean distinct, Expression arg1, Expression arg2) {
super("covar", distinct, arg1, arg2);
this(distinct, false, arg1, arg2);
}
public Covar(boolean distinct, boolean alwaysNullable, Expression arg1, Expression arg2) {
super("covar", distinct, alwaysNullable, arg1, arg2);
}
/**
@ -70,7 +73,12 @@ public class Covar extends AggregateFunction
@Override
public Covar withDistinctAndChildren(boolean distinct, List<Expression> children) {
Preconditions.checkArgument(children.size() == 2);
return new Covar(distinct, children.get(0), children.get(1));
return new Covar(distinct, alwaysNullable, children.get(0), children.get(1));
}
@Override
public Covar withAlwaysNullable(boolean alwaysNullable) {
return new Covar(distinct, alwaysNullable, children.get(0), children.get(1));
}
@Override