From 13964bb1eee094e1105eea9ebcbcaba00f426cb6 Mon Sep 17 00:00:00 2001 From: Uniqueyou Date: Fri, 24 Jan 2025 17:28:27 +0800 Subject: [PATCH] branch-2.1: [fix](sql) Wrong result of tosql for drop column with rollup #47153 (#47206) pick: https://github.com/apache/doris/pull/47153 --- .../main/java/org/apache/doris/analysis/DropColumnClause.java | 2 +- .../java/org/apache/doris/analysis/DropColumnClauseTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/DropColumnClause.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/DropColumnClause.java index cbc2c12b1e..0a9a540017 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/DropColumnClause.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/DropColumnClause.java @@ -80,7 +80,7 @@ public class DropColumnClause extends AlterTableClause { StringBuilder sb = new StringBuilder(); sb.append("DROP COLUMN `").append(colName).append("`"); if (rollupName != null) { - sb.append(" IN `").append(rollupName).append("`"); + sb.append(" FROM `").append(rollupName).append("`"); } return sb.toString(); } diff --git a/fe/fe-core/src/test/java/org/apache/doris/analysis/DropColumnClauseTest.java b/fe/fe-core/src/test/java/org/apache/doris/analysis/DropColumnClauseTest.java index cd29e6995c..540c26a053 100644 --- a/fe/fe-core/src/test/java/org/apache/doris/analysis/DropColumnClauseTest.java +++ b/fe/fe-core/src/test/java/org/apache/doris/analysis/DropColumnClauseTest.java @@ -42,7 +42,7 @@ public class DropColumnClauseTest { clause.analyze(analyzer); Assert.assertEquals("rollup", clause.getRollupName()); Assert.assertNull("rollup", clause.getProperties()); - Assert.assertEquals("DROP COLUMN `col` IN `rollup`", clause.toString()); + Assert.assertEquals("DROP COLUMN `col` FROM `rollup`", clause.toString()); } @Test(expected = AnalysisException.class)