From 14dcdd188e8fe5de69ae4f4cb3117cccdd292fda Mon Sep 17 00:00:00 2001
From: Lei Zhang <27994433+SWJTU-ZhangLei@users.noreply.github.com>
Date: Sun, 19 Mar 2023 11:39:19 +0800
Subject: [PATCH] [fix](fe) fix MetricRepo.THRIFT_COUNTER_RPC_ALL
 NullPointException (#17552)

---
 .../main/java/org/apache/doris/service/FeServer.java  | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
index 11b224df02..32d055069a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
@@ -50,7 +50,9 @@ public class FeServer {
                 (proxy, method, args) -> {
                     long begin = System.currentTimeMillis();
                     String name = method.getName();
-                    MetricRepo.THRIFT_COUNTER_RPC_ALL.getOrAdd(name).increase(1L);
+                    if (MetricRepo.isInit) {
+                        MetricRepo.THRIFT_COUNTER_RPC_ALL.getOrAdd(name).increase(1L);
+                    }
                     feServiceLogger.debug("receive request for {}", name);
                     Object r = null;
                     try {
@@ -61,8 +63,11 @@ public class FeServer {
                         throw t;
                     } finally {
                         feServiceLogger.debug("finish process request for {}", name);
-                        long end = System.currentTimeMillis();
-                        MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name).increase(end - begin);
+                        if (MetricRepo.isInit) {
+                            long end = System.currentTimeMillis();
+                            MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name)
+                                    .increase(end - begin);
+                        }
                     }
                     return r;
                 });