database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](Nereids): reject infer distinct when children exist NLJ (#21391)

Browse Source
This commit is contained in:
jakevin
2023-06-30 20:29:48 +08:00
committed by GitHub
parent 4117f0b93b
commit 18b7d84436
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/InferSetOperatorDistinct.java
View File

@ -22,6 +22,8 @@ import org.apache.doris.nereids.rules.RuleType;
import org.apache.doris.nereids.trees.plans.Plan;
import org.apache.doris.nereids.trees.plans.algebra.SetOperation.Qualifier;
import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
import com.google.common.collect.ImmutableList;
@ -41,7 +43,12 @@ public class InferSetOperatorDistinct extends OneRewriteRuleFactory {
public Rule build() {
return logicalSetOperation()
.when(operation -> operation.getQualifier() == Qualifier.DISTINCT)
.when(operation -> operation.children().stream().allMatch(this::rejectNLJ))
.then(setOperation -> {
if (setOperation.children().stream().anyMatch(child -> child instanceof LogicalAggregate)) {
return null;
}
List<Plan> newChildren = setOperation.children().stream()
.map(child -> new LogicalAggregate<>(ImmutableList.copyOf(child.getOutput()), child))
.collect(ImmutableList.toImmutableList());
@ -51,4 +58,16 @@ public class InferSetOperatorDistinct extends OneRewriteRuleFactory {
return setOperation.withChildren(newChildren);
}).toRule(RuleType.INFER_SET_OPERATOR_DISTINCT);
}
// if children exist NLJ, we can't infer distinct
private boolean rejectNLJ(Plan plan) {
if (plan instanceof LogicalProject) {
plan = plan.child(0);
}
if (plan instanceof LogicalJoin) {
LogicalJoin<?, ?> join = (LogicalJoin<?, ?>) plan;
return join.getOtherJoinConjuncts().isEmpty();
}
return true;
}
}