database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](decimalv3) fix failed on test_dup_tab_decimalv3 due to wrong precision (#21890)

Browse Source 
fix failed on test_dup_tab_decimalv3 due to wrong precision
This commit is contained in:
Pxl
2023-07-18 12:53:09 +08:00
committed by GitHub
parent e1a116af94
commit 19492b06c1
4 changed files with 45 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
be/src/vec/exec/scan/vscan_node.cpp
View File

@ -65,9 +65,12 @@
namespace doris::vectorized {
#define RETURN_IF_PUSH_DOWN(stmt) \
#define RETURN_IF_PUSH_DOWN(stmt, status) \
if (pdt == PushDownType::UNACCEPTABLE) { \
stmt; \
status = stmt; \
if (!status.ok()) { \
return; \
} \
} else { \
return; \
}
@ -472,6 +475,7 @@ Status VScanNode::_normalize_predicate(const VExprSPtr& conjunct_expr_root, VExp
}
if (_is_predicate_acting_on_slot(cur_expr, in_predicate_checker, &slot, &range) ||
_is_predicate_acting_on_slot(cur_expr, eq_predicate_checker, &slot, &range)) {
Status status = Status::OK();
std::visit(
[&](auto& value_range) {
Defer mark_runtime_filter_flag {[&]() {
@ -479,27 +483,36 @@ Status VScanNode::_normalize_predicate(const VExprSPtr& conjunct_expr_root, VExp
_is_runtime_filter_predicate);
}};
RETURN_IF_PUSH_DOWN(_normalize_in_and_eq_predicate(
cur_expr, context, slot, value_range, &pdt));
cur_expr, context, slot, value_range, &pdt),
status);
RETURN_IF_PUSH_DOWN(_normalize_not_in_and_not_eq_predicate(
cur_expr, context, slot, value_range, &pdt));
cur_expr, context, slot, value_range, &pdt),
status);
RETURN_IF_PUSH_DOWN(_normalize_is_null_predicate(
cur_expr, context, slot, value_range, &pdt));
cur_expr, context, slot, value_range, &pdt),
status);
RETURN_IF_PUSH_DOWN(_normalize_noneq_binary_predicate(
cur_expr, context, slot, value_range, &pdt));
cur_expr, context, slot, value_range, &pdt),
status);
RETURN_IF_PUSH_DOWN(_normalize_match_predicate(cur_expr, context, slot,
value_range, &pdt));
value_range, &pdt),
status);
if (_is_key_column(slot->col_name())) {
RETURN_IF_PUSH_DOWN(
_normalize_bitmap_filter(cur_expr, context, slot, &pdt));
_normalize_bitmap_filter(cur_expr, context, slot, &pdt),
status);
RETURN_IF_PUSH_DOWN(
_normalize_bloom_filter(cur_expr, context, slot, &pdt));
_normalize_bloom_filter(cur_expr, context, slot, &pdt),
status);
if (_state->enable_function_pushdown()) {
RETURN_IF_PUSH_DOWN(_normalize_function_filters(
cur_expr, context, slot, &pdt));
cur_expr, context, slot, &pdt),
status);
}
}
},
*range);
RETURN_IF_ERROR(status);
}
if (pdt == PushDownType::UNACCEPTABLE &&
@ -772,6 +785,11 @@ Status VScanNode::_normalize_in_and_eq_predicate(VExpr* expr, VExprContext* expr
temp_range, reinterpret_cast<void*>(&val),
ColumnValueRange<T>::add_fixed_value_range, fn_name));
} else {
if (sizeof(typename PrimitiveTypeTraits<T>::CppType) != value.size) {
return Status::InternalError(
"PrimitiveType {} meet invalid input value size {}, expect size {}", T,
value.size, sizeof(typename PrimitiveTypeTraits<T>::CppType));
}
RETURN_IF_ERROR(_change_value_range<true>(
temp_range, reinterpret_cast<void*>(const_cast<char*>(value.data)),
ColumnValueRange<T>::add_fixed_value_range, fn_name));