database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[enhancement](memory) Remove unused reservation tracker (#11969)

Browse Source
This commit is contained in:
Xinyi Zou
2022-08-24 08:49:34 +08:00
committed by GitHub
parent 477899af8e
commit 1fc5515a78
27 changed files with 52 additions and 1691 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
be/src/exec/exec_node.cpp
View File

@ -53,7 +53,6 @@
#include "odbc_scan_node.h"
#include "runtime/descriptors.h"
#include "runtime/exec_env.h"
#include "runtime/initial_reservations.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/row_batch.h"
#include "runtime/runtime_state.h"
@ -286,9 +285,6 @@ Status ExecNode::close(RuntimeState* state) {
}
if (_buffer_pool_client.is_registered()) {
VLOG_FILE << _id << " returning reservation " << _resource_profile.min_reservation;
state->initial_reservations()->Return(&_buffer_pool_client,
_resource_profile.min_reservation);
state->exec_env()->buffer_pool()->DeregisterClient(&_buffer_pool_client);
}
@ -727,11 +723,8 @@ Status ExecNode::claim_buffer_reservation(RuntimeState* state) {
}
ss << print_plan_node_type(_type) << " id=" << _id << " ptr=" << this;
RETURN_IF_ERROR(buffer_pool->RegisterClient(ss.str(), state->instance_buffer_reservation(),
buffer_pool->GetSystemBytesLimit(),
runtime_profile(), &_buffer_pool_client));
RETURN_IF_ERROR(buffer_pool->RegisterClient(ss.str(), runtime_profile(), &_buffer_pool_client));
state->initial_reservations()->Claim(&_buffer_pool_client, _resource_profile.min_reservation);
/*
if (debug_action_ == TDebugAction::SET_DENY_RESERVATION_PROBABILITY &&
(debug_phase_ == TExecNodePhase::PREPARE || debug_phase_ == TExecNodePhase::OPEN)) {
@ -744,10 +737,6 @@ Status ExecNode::claim_buffer_reservation(RuntimeState* state) {
return Status::OK();
}
Status ExecNode::release_unused_reservation() {
return _buffer_pool_client.DecreaseReservationTo(_resource_profile.min_reservation);
}
void ExecNode::release_block_memory(vectorized::Block& block, uint16_t child_idx) {
DCHECK(child_idx < _children.size());
block.clear_column_data(child(child_idx)->row_desc().num_materialized_slots());