database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](ut) fix abs function ut (#7938)

Browse Source
This commit is contained in:
Pxl
2022-01-31 14:58:29 +08:00
committed by GitHub
parent 3f221e1d0b
commit 2003da7cf9
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
be/src/exprs/math_functions.cpp
View File

@ -106,6 +106,11 @@ DoubleVal MathFunctions::e(FunctionContext* ctx) {
return DoubleVal(M_E);
}
// libc++ did not have std::abs for int128
__int128_t largeint_abs(__int128_t x) {
return x > 0 ? x : -x;
}
DecimalV2Val MathFunctions::abs(FunctionContext* ctx, const doris_udf::DecimalV2Val& val) {
if (val.is_null) {
return DecimalV2Val::null();
@ -113,7 +118,7 @@ DecimalV2Val MathFunctions::abs(FunctionContext* ctx, const doris_udf::DecimalV2
if (UNLIKELY(val.val == MIN_INT128)) {
return DecimalV2Val::null();
} else {
return DecimalV2Val(val.val > 0 ? val.val : -val.val);
return DecimalV2Val(largeint_abs(val.val));
}
}
@ -124,7 +129,7 @@ LargeIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::LargeIntVa
if (UNLIKELY(val.val == MIN_INT128)) {
return LargeIntVal::null();
} else {
return LargeIntVal(val.val > 0 ? val.val : -val.val);
return LargeIntVal(largeint_abs(val.val));
}
}
@ -132,28 +137,28 @@ LargeIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::BigIntVal&
if (val.is_null) {
return LargeIntVal::null();
}
return LargeIntVal(__int128(std::abs(val.val)));
return LargeIntVal(largeint_abs(__int128(val.val)));
}
BigIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::IntVal& val) {
if (val.is_null) {
return BigIntVal::null();
}
return BigIntVal(int64_t(std::abs(val.val)));
return BigIntVal(std::abs(int64_t(val.val)));
}
IntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::SmallIntVal& val) {
if (val.is_null) {
return IntVal::null();
}
return IntVal(int32_t(std::abs(val.val)));
return IntVal(std::abs(int32_t(val.val)));
}
SmallIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::TinyIntVal& val) {
if (val.is_null) {
return SmallIntVal::null();
}
return SmallIntVal(int16_t(std::abs(val.val)));
return SmallIntVal(std::abs(int16_t(val.val)));
}
// Generates a UDF that always calls FN() on the input val and returns it.