From 206aeabe9a2467e7c384d912d8079fbc0bd24fad Mon Sep 17 00:00:00 2001 From: Gabriel Date: Mon, 23 Oct 2023 17:50:46 +0800 Subject: [PATCH] [pipelineX](minor) remove unused timer (#25766) --- be/src/pipeline/exec/sort_sink_operator.cpp | 6 ------ be/src/pipeline/exec/sort_sink_operator.h | 3 --- be/src/pipeline/exec/sort_source_operator.cpp | 11 +---------- be/src/pipeline/exec/sort_source_operator.h | 5 +---- 4 files changed, 2 insertions(+), 23 deletions(-) diff --git a/be/src/pipeline/exec/sort_sink_operator.cpp b/be/src/pipeline/exec/sort_sink_operator.cpp index 5035cd94a2..9da23d33cd 100644 --- a/be/src/pipeline/exec/sort_sink_operator.cpp +++ b/be/src/pipeline/exec/sort_sink_operator.cpp @@ -65,12 +65,6 @@ Status SortSinkLocalState::init(RuntimeState* state, LocalSinkStateInfo& info) { _profile->add_info_string("TOP-N", p._limit == -1 ? "false" : "true"); _memory_usage_counter = ADD_LABEL_COUNTER(_profile, "MemoryUsage"); - _sort_blocks_memory_usage = - ADD_CHILD_COUNTER(_profile, "SortBlocks", TUnit::BYTES, "MemoryUsage"); - - _child_get_next_timer = ADD_TIMER(_profile, "ChildGetResultTime"); - _sink_timer = ADD_TIMER(_profile, "PartialSortTotalTime"); - return Status::OK(); } diff --git a/be/src/pipeline/exec/sort_sink_operator.h b/be/src/pipeline/exec/sort_sink_operator.h index 84e4268996..69662f25b4 100644 --- a/be/src/pipeline/exec/sort_sink_operator.h +++ b/be/src/pipeline/exec/sort_sink_operator.h @@ -65,9 +65,6 @@ private: vectorized::VSortExecExprs _vsort_exec_exprs; RuntimeProfile::Counter* _memory_usage_counter; - RuntimeProfile::Counter* _sort_blocks_memory_usage; - RuntimeProfile::Counter* _child_get_next_timer = nullptr; - RuntimeProfile::Counter* _sink_timer = nullptr; // topn top value vectorized::Field old_top {vectorized::Field::Types::Null}; diff --git a/be/src/pipeline/exec/sort_source_operator.cpp b/be/src/pipeline/exec/sort_source_operator.cpp index 32218879ff..de5cd937be 100644 --- a/be/src/pipeline/exec/sort_source_operator.cpp +++ b/be/src/pipeline/exec/sort_source_operator.cpp @@ -26,15 +26,7 @@ namespace doris::pipeline { OPERATOR_CODE_GENERATOR(SortSourceOperator, SourceOperator) SortLocalState::SortLocalState(RuntimeState* state, OperatorXBase* parent) - : PipelineXLocalState(state, parent), _get_next_timer(nullptr) {} - -Status SortLocalState::init(RuntimeState* state, LocalStateInfo& info) { - RETURN_IF_ERROR(PipelineXLocalState::init(state, info)); - SCOPED_TIMER(profile()->total_time_counter()); - SCOPED_TIMER(_open_timer); - _get_next_timer = ADD_TIMER(profile(), "GetResultTime"); - return Status::OK(); -} + : PipelineXLocalState(state, parent) {} SortSourceOperatorX::SortSourceOperatorX(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs) @@ -44,7 +36,6 @@ Status SortSourceOperatorX::get_block(RuntimeState* state, vectorized::Block* bl SourceState& source_state) { CREATE_LOCAL_STATE_RETURN_IF_ERROR(local_state); SCOPED_TIMER(local_state.profile()->total_time_counter()); - SCOPED_TIMER(local_state._get_next_timer); bool eos = false; RETURN_IF_ERROR_OR_CATCH_EXCEPTION( local_state._shared_state->sorter->get_next(state, block, &eos)); diff --git a/be/src/pipeline/exec/sort_source_operator.h b/be/src/pipeline/exec/sort_source_operator.h index 4a50b91648..8521715154 100644 --- a/be/src/pipeline/exec/sort_source_operator.h +++ b/be/src/pipeline/exec/sort_source_operator.h @@ -50,13 +50,10 @@ class SortLocalState final : public PipelineXLocalState { public: ENABLE_FACTORY_CREATOR(SortLocalState); SortLocalState(RuntimeState* state, OperatorXBase* parent); - - Status init(RuntimeState* state, LocalStateInfo& info) override; + ~SortLocalState() override = default; private: friend class SortSourceOperatorX; - - RuntimeProfile::Counter* _get_next_timer = nullptr; }; class SortSourceOperatorX final : public OperatorX {