database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug] fix decimal arithmetic calculations (#10963)

Browse Source
This commit is contained in:
Gabriel
2022-07-18 14:35:07 +08:00
committed by GitHub
parent 8c544b6e13
commit 238395e282
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
be/src/vec/functions/function_binary_arithmetic.h
View File

@ -745,14 +745,11 @@ private:
OpTraits::is_division);
typename ResultDataType::FieldType scale_a;
typename ResultDataType::FieldType scale_b;
if constexpr (OpTraits::is_division && IsDataTypeDecimal<RightDataType>) {
scale_a = type_right.get_scale_multiplier();
scale_b = 1;
} else {
scale_a = type.scale_factor_for(type_left, OpTraits::is_multiply);
scale_b = type.scale_factor_for(type_right,
OpTraits::is_multiply || OpTraits::is_division);
}
// TODO(Gabriel): precision and scale need to be processed for decimalv3, now we just
// keep the same behavior as before
scale_a = type.scale_factor_for(type_left, OpTraits::is_multiply);
scale_b = type.scale_factor_for(type_right, OpTraits::is_multiply || OpTraits::is_division);
return std::make_tuple(type, scale_a, scale_b);
}