From 27a21aa1509693813e36b155935d1aa78a260c42 Mon Sep 17 00:00:00 2001 From: deardeng <565620795@qq.com> Date: Fri, 10 Nov 2023 12:57:13 +0800 Subject: [PATCH] [fix](balance) Delete useless debug log (#26732) --- .../apache/doris/clone/DiskRebalancer.java | 26 ------------------- .../apache/doris/clone/TabletScheduler.java | 2 -- 2 files changed, 28 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/clone/DiskRebalancer.java b/fe/fe-core/src/main/java/org/apache/doris/clone/DiskRebalancer.java index 0a7ce1b8f5..5edca91444 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/clone/DiskRebalancer.java +++ b/fe/fe-core/src/main/java/org/apache/doris/clone/DiskRebalancer.java @@ -120,7 +120,6 @@ public class DiskRebalancer extends Rebalancer { @Override protected List selectAlternativeTabletsForCluster( LoadStatisticForTag clusterStat, TStorageMedium medium) { - LOG.info("dx test enter selectAlternativeTabletsForCluster"); List alternativeTablets = Lists.newArrayList(); // get classification of backends @@ -186,17 +185,7 @@ public class DiskRebalancer extends Rebalancer { Set pathHigh = Sets.newHashSet(); // we only select tablets from available high load path beStat.getPathStatisticByClass(pathLow, pathMid, pathHigh, medium); - LOG.info("dx test select before low={} mid={} high={} medium={}", pathLow, pathMid, pathHigh, medium); // check if BE has low and high paths for balance after reclassification - pathHigh.add(-2606726262674133323L); - pathHigh.add(384536254535458899L); - pathHigh.add(528047762753362128L); - pathLow.add(1252949013258184268L); - pathMid.remove(384536254535458899L); - pathMid.remove(528047762753362128L); - pathMid.remove(-2606726262674133323L); - pathMid.remove(1252949013258184268L); - LOG.info("dx test select after low={} mid={} high={} medium={}", pathLow, pathMid, pathHigh, medium); if (!checkAndReclassifyPaths(pathLow, pathMid, pathHigh)) { continue; } @@ -284,7 +273,6 @@ public class DiskRebalancer extends Rebalancer { medium, alternativeTablets.size(), alternativeTablets.stream().mapToLong(TabletSchedCtx::getTabletId).toArray()); } - LOG.info("dx test out selectAlternativeTabletsForCluster, alternativeTablets={}", alternativeTablets); return alternativeTablets; } @@ -296,7 +284,6 @@ public class DiskRebalancer extends Rebalancer { */ @Override public void completeSchedCtx(TabletSchedCtx tabletCtx) throws SchedException { - LOG.info("dx test enter completeSchedCtx"); LoadStatisticForTag clusterStat = statisticMap.get(tabletCtx.getTag()); if (clusterStat == null) { throw new SchedException(Status.UNRECOVERABLE, @@ -353,18 +340,6 @@ public class DiskRebalancer extends Rebalancer { Set pathMid = Sets.newHashSet(); Set pathHigh = Sets.newHashSet(); beStat.getPathStatisticByClass(pathLow, pathMid, pathHigh, tabletCtx.getStorageMedium()); - LOG.info("dx test complete before low={} mid={} high={} medium={}", - pathLow, pathMid, pathHigh, tabletCtx.getStorageMedium()); - pathHigh.add(-2606726262674133323L); - pathHigh.add(384536254535458899L); - pathHigh.add(528047762753362128L); - pathLow.add(1252949013258184268L); - pathMid.remove(384536254535458899L); - pathMid.remove(528047762753362128L); - pathMid.remove(-2606726262674133323L); - pathMid.remove(1252949013258184268L); - LOG.info("dx test complete after low={} mid={} high={} medium={}", - pathLow, pathMid, pathHigh, tabletCtx.getStorageMedium()); if (pathHigh.contains(replica.getPathHash())) { pathLow.addAll(pathMid); } else if (!pathMid.contains(replica.getPathHash())) { @@ -407,6 +382,5 @@ public class DiskRebalancer extends Rebalancer { if (!setDest) { throw new SchedException(Status.UNRECOVERABLE, "unable to find low load path"); } - LOG.info("dx test out completeSchedCtx"); } } diff --git a/fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java b/fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java index beee677d2c..ffae27c963 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java +++ b/fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java @@ -621,8 +621,6 @@ public class TabletScheduler extends MasterDaemon { Optional destReplica = tabletCtx.getReplicas() .stream().filter(replica -> replica.getBackendId() == tabletCtx.getDestBackendId()).findAny(); if (destReplica.isPresent() && tabletCtx.getDestPathHash() != -1) { - LOG.info("dx test success report old {} : new {}", - destReplica.get().getPathHash(), tabletCtx.getDestPathHash()); destReplica.get().setPathHash(tabletCtx.getDestPathHash()); } }