Support subquery with non-scalar result in Binary predicate and Between-and predicate (#2360)
This commit add a new plan node named AssertNumRowsNode which is used to determine whether the number of rows exceeds the limit. The subquery in Binary predicate and Between-and predicate should be added a AssertNumRowsNode which is used to determine whether the number of rows in subquery is more than 1. If the number of rows in subquery is more than 1, the query will be cancelled. For example: There are 4 rows in table t1. Query: select c1 from t1 where c1=(select c2 from t1); Result: ERROR 1064 (HY000): Expected no more than 1 to be returned by expression select c2 from t1 ISSUE-2270 TPC-DS 6,54,58
This commit is contained in:
75
be/src/exec/assert_num_rows_node.cpp
Normal file
75
be/src/exec/assert_num_rows_node.cpp
Normal file
@ -0,0 +1,75 @@
|
||||
// Licensed to the Apache Software Foundation (ASF) under one
|
||||
// or more contributor license agreements. See the NOTICE file
|
||||
// distributed with this work for additional information
|
||||
// regarding copyright ownership. The ASF licenses this file
|
||||
// to you under the Apache License, Version 2.0 (the
|
||||
// "License"); you may not use this file except in compliance
|
||||
// with the License. You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing,
|
||||
// software distributed under the License is distributed on an
|
||||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
// KIND, either express or implied. See the License for the
|
||||
// specific language governing permissions and limitations
|
||||
// under the License.
|
||||
|
||||
#include "exec/assert_num_rows_node.h"
|
||||
|
||||
#include "runtime/row_batch.h"
|
||||
#include "runtime/runtime_state.h"
|
||||
#include "util/runtime_profile.h"
|
||||
#include "gen_cpp/PlanNodes_types.h"
|
||||
#include "gutil/strings/substitute.h"
|
||||
|
||||
namespace doris {
|
||||
|
||||
AssertNumRowsNode::AssertNumRowsNode(
|
||||
ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs) :
|
||||
ExecNode(pool, tnode, descs),
|
||||
_desired_num_rows(tnode.assert_num_rows_node.desired_num_rows),
|
||||
_subquery_string(tnode.assert_num_rows_node.subquery_string) {
|
||||
}
|
||||
|
||||
Status AssertNumRowsNode::init(const TPlanNode& tnode, RuntimeState* state) {
|
||||
RETURN_IF_ERROR(ExecNode::init(tnode, state));
|
||||
return Status::OK();
|
||||
}
|
||||
|
||||
Status AssertNumRowsNode::prepare(RuntimeState* state) {
|
||||
RETURN_IF_ERROR(ExecNode::prepare(state));
|
||||
return Status::OK();
|
||||
}
|
||||
|
||||
Status AssertNumRowsNode::open(RuntimeState* state) {
|
||||
SCOPED_TIMER(_runtime_profile->total_time_counter());
|
||||
RETURN_IF_ERROR(ExecNode::open(state));
|
||||
return Status::OK();
|
||||
}
|
||||
|
||||
Status AssertNumRowsNode::get_next(RuntimeState* state, RowBatch* output_batch, bool* eos) {
|
||||
RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT));
|
||||
SCOPED_TIMER(_runtime_profile->total_time_counter());
|
||||
output_batch->reset();
|
||||
child(0)->get_next(state, output_batch, eos);
|
||||
_num_rows_returned += output_batch->num_rows();
|
||||
if (_num_rows_returned > _desired_num_rows) {
|
||||
LOG(INFO) << "Expected no more than " << _desired_num_rows << " to be returned by expression "
|
||||
<< _subquery_string;
|
||||
return Status::Cancelled(strings::Substitute(
|
||||
"Expected no more than $0 to be returned by expression $1",
|
||||
_desired_num_rows, _subquery_string));
|
||||
}
|
||||
COUNTER_SET(_rows_returned_counter, _num_rows_returned);
|
||||
return Status::OK();
|
||||
}
|
||||
|
||||
Status AssertNumRowsNode::close(RuntimeState* state) {
|
||||
if (is_closed()) {
|
||||
return Status::OK();
|
||||
}
|
||||
return ExecNode::close(state);
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user