From 2b3e7589b74fd5657012378a009479d15005ec40 Mon Sep 17 00:00:00 2001 From: starocean999 <40539150+starocean999@users.noreply.github.com> Date: Tue, 23 Jan 2024 19:38:27 +0800 Subject: [PATCH] [fix](nereids)group by expr may be lost in EliminateGroupByConstant rule (#30274) --- .../doris/nereids/rules/analysis/EliminateGroupByConstant.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java index e7fa14e5cb..e683153e9a 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java @@ -67,7 +67,7 @@ public class EliminateGroupByConstant extends OneRewriteRuleFactory { lit = expression; } } - if (slotGroupByExprs.isEmpty() && lit != null && aggregate.getAggregateFunctions().isEmpty()) { + if (slotGroupByExprs.isEmpty() && lit != null) { slotGroupByExprs.add(lit); } return aggregate.withGroupByAndOutput(ImmutableList.copyOf(slotGroupByExprs), outputExprs);