database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improvement](function) standardize some ip functions' signatures #29614

Browse Source 
The signatures of functions in these PRs should be more standard:
#27342,
#25510,
#20936,
including the following:
ipv4numtostring,
ipv4stringtonum,
ipv4stringtonumordefault,
ipv4stringtonumornull,
ipv6numtostring.

This PR will add necessary underscores between the words of each of them,
like changing ipv4numtostring to ipv4_num_to_string.
This commit is contained in:
Chester
2024-01-06 16:16:38 +08:00
committed by GitHub
parent 5789b7e380
commit 2c888667ed
21 changed files with 215 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java
View File

@ -591,11 +591,11 @@ public class BuiltinScalarFunctions implements FunctionHelper {
scalar(Initcap.class, "initcap"),
scalar(InnerProduct.class, "inner_product"),
scalar(Instr.class, "instr"),
scalar(Ipv4NumToString.class, "ipv4numtostring", "inet_ntoa"),
scalar(Ipv4StringToNum.class, "ipv4stringtonum", "inet_aton"),
scalar(Ipv4StringToNumOrDefault.class, "ipv4stringtonumordefault"),
scalar(Ipv4StringToNumOrNull.class, "ipv4stringtonumornull"),
scalar(Ipv6NumToString.class, "ipv6numtostring", "inet6_ntoa"),
scalar(Ipv4NumToString.class, "ipv4_num_to_string", "inet_ntoa"),
scalar(Ipv4StringToNum.class, "ipv4_string_to_num", "inet_aton"),
scalar(Ipv4StringToNumOrDefault.class, "ipv4_string_to_num_or_default"),
scalar(Ipv4StringToNumOrNull.class, "ipv4_string_to_num_or_null"),
scalar(Ipv6NumToString.class, "ipv6_num_to_string", "inet6_ntoa"),
scalar(Ipv6StringToNum.class, "ipv6_string_to_num", "inet6_aton"),
scalar(Ipv6StringToNumOrDefault.class, "ipv6_string_to_num_or_default"),
scalar(Ipv6StringToNumOrNull.class, "ipv6_string_to_num_or_null"),

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Ipv4NumToString.java
View File

@ -35,7 +35,7 @@ import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* scalar function Ipv4NumToString
* scalar function ipv4_num_to_string
*/
public class Ipv4NumToString extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNullable {
@ -47,13 +47,13 @@ public class Ipv4NumToString extends ScalarFunction
FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(BigIntType.INSTANCE));
public Ipv4NumToString(Expression arg0) {
super("ipv4numtostring", arg0);
super("ipv4_num_to_string", arg0);
}
@Override
public Ipv4NumToString withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() == 1,
"ipv4numtostring accept 1 args, but got %s (%s)",
"ipv4_num_to_string accept 1 args, but got %s (%s)",
children.size(),
children);
return new Ipv4NumToString(children.get(0));

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Ipv4StringToNum.java
View File

@ -33,7 +33,7 @@ import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* scalar function Ipv4StringToNum
* scalar function ipv4_string_to_num
*/
public class Ipv4StringToNum extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNotNullable {
@ -43,13 +43,13 @@ public class Ipv4StringToNum extends ScalarFunction
FunctionSignature.ret(BigIntType.INSTANCE).args(StringType.INSTANCE));
public Ipv4StringToNum(Expression arg0) {
super("ipv4stringtonum", arg0);
super("ipv4_string_to_num", arg0);
}
@Override
public Ipv4StringToNum withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() == 1,
"ipv4stringtonum accept 1 args, but got %s (%s)",
"ipv4_string_to_num accept 1 args, but got %s (%s)",
children.size(),
children);
return new Ipv4StringToNum(children.get(0));

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Ipv4StringToNumOrDefault.java
View File

@ -33,7 +33,7 @@ import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* scalar function Ipv4StringToNumOrDefault
* scalar function ipv4_string_to_num_or_default
*/
public class Ipv4StringToNumOrDefault extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNotNullable {
@ -43,13 +43,13 @@ public class Ipv4StringToNumOrDefault extends ScalarFunction
FunctionSignature.ret(BigIntType.INSTANCE).args(StringType.INSTANCE));
public Ipv4StringToNumOrDefault(Expression arg0) {
super("ipv4stringtonumordefault", arg0);
super("ipv4_string_to_num_or_default", arg0);
}
@Override
public Ipv4StringToNumOrDefault withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() == 1,
"ipv4stringtonumordefault accept 1 args, but got %s (%s)",
"ipv4_string_to_num_or_default accept 1 args, but got %s (%s)",
children.size(),
children);
return new Ipv4StringToNumOrDefault(children.get(0));

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Ipv4StringToNumOrNull.java
View File

@ -33,7 +33,7 @@ import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* scalar function Ipv4StringToNumOrNull
* scalar function ipv4_string_to_num_or_null
*/
public class Ipv4StringToNumOrNull extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNullable {
@ -43,13 +43,13 @@ public class Ipv4StringToNumOrNull extends ScalarFunction
FunctionSignature.ret(BigIntType.INSTANCE).args(StringType.INSTANCE));
public Ipv4StringToNumOrNull(Expression arg0) {
super("ipv4stringtonumornull", arg0);
super("ipv4_string_to_num_or_null", arg0);
}
@Override
public Ipv4StringToNumOrNull withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() == 1,
"ipv4stringtonumornull accept 1 args, but got %s (%s)",
"ipv4_string_to_num_or_null accept 1 args, but got %s (%s)",
children.size(),
children);
return new Ipv4StringToNumOrNull(children.get(0));

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Ipv6NumToString.java
View File

@ -32,7 +32,7 @@ import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* scalar function Ipv6NumToString
* scalar function ipv6_num_to_string
*/
public class Ipv6NumToString extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNullable {
@ -42,13 +42,13 @@ public class Ipv6NumToString extends ScalarFunction
FunctionSignature.ret(StringType.INSTANCE).args(StringType.INSTANCE));
public Ipv6NumToString(Expression arg0) {
super("ipv6numtostring", arg0);
super("ipv6_num_to_string", arg0);
}
@Override
public Ipv6NumToString withChildren(List<Expression> children) {
Preconditions.checkArgument(children.size() == 1,
"ipv6numtostring accept 1 args, but got %s (%s)",
"ipv6_num_to_string accept 1 args, but got %s (%s)",
children.size(),
children);
return new Ipv6NumToString(children.get(0));