From 32530113cfdf44fd397df9587af52e3a8c8d47f0 Mon Sep 17 00:00:00 2001 From: abmdocrt Date: Thu, 25 Jul 2024 14:48:02 +0800 Subject: [PATCH] [cherry-pick](branch-2.1) Fix some group commit forward to master problems (#38345) ## Proposed changes Pick #38228 #38265 --- .../main/java/org/apache/doris/httpv2/rest/LoadAction.java | 3 +++ .../java/org/apache/doris/service/FrontendServiceImpl.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java index edcbc2dd7f..030aced411 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java +++ b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java @@ -365,6 +365,9 @@ public class LoadAction extends RestBaseController { ctx.setEnv(Env.getCurrentEnv()); ctx.setThreadLocalInfo(); ctx.setRemoteIP(request.getRemoteAddr()); + // We set this variable to fulfill required field 'user' in + // TMasterOpRequest(FrontendService.thrift) + ctx.setQualifiedUser(Auth.ADMIN_USER); ctx.setThreadLocalInfo(); try { diff --git a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java index 448b1231dd..4935e026f1 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java @@ -1010,7 +1010,7 @@ public class FrontendServiceImpl implements FrontendService.Iface { result.setPacket("".getBytes()); return result; } - if (params.getGroupCommitInfo().isGetGroupCommitLoadBeId()) { + if (params.getGroupCommitInfo() != null && params.getGroupCommitInfo().isGetGroupCommitLoadBeId()) { final TGroupCommitInfo info = params.getGroupCommitInfo(); final TMasterOpResult result = new TMasterOpResult(); try { @@ -1023,7 +1023,7 @@ public class FrontendServiceImpl implements FrontendService.Iface { result.setPacket("".getBytes()); return result; } - if (params.getGroupCommitInfo().isUpdateLoadData()) { + if (params.getGroupCommitInfo() != null && params.getGroupCommitInfo().isUpdateLoadData()) { final TGroupCommitInfo info = params.getGroupCommitInfo(); final TMasterOpResult result = new TMasterOpResult(); Env.getCurrentEnv().getGroupCommitManager()