From 33aaacf2fa5366381e0d7382762b9273486d5431 Mon Sep 17 00:00:00 2001
From: Vallish Pai <vallishpai@gmail.com>
Date: Sun, 18 Feb 2024 09:09:25 +0530
Subject: [PATCH] [Bug] (plsql) procedure call to a non existing procedure,
 returning success (#31019)

Issue Number: close. #31018

state was set OK even in failure case. changed it.
---
 .../org/apache/doris/plsql/executor/PlSqlOperation.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java b/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
index 525ca612cd..b98507c1a4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
@@ -49,10 +49,11 @@ public class PlSqlOperation {
         result.reset();
         try {
             Arguments args = new Arguments();
-            args.parse(new String[] {"-e", statement});
+            args.parse(new String[] { "-e", statement });
             exec.parseAndEval(args);
             // Exception is not thrown after catch.
-            // For example, select a not exist table will return empty results, exception will put into signals.
+            // For example, select a not exist table will return empty results, exception
+            // will put into signals.
             exec.printExceptions();
             String error = result.getError();
             String msg = result.getMsg();
@@ -62,7 +63,6 @@ public class PlSqlOperation {
                 ctx.getState().setOk(0, 0, msg);
             }
             ctx.getMysqlChannel().reset();
-            ctx.getState().setOk();
             ctx.setRunProcedure(false);
             ctx.setProcedureExec(null);
         } catch (Exception e) {