database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improvement](functions) avoid copying of block in create_block_with_nested_columns (#21526)

Browse Source 
avoid copying of block in create_block_with_nested_columns
This commit is contained in:
Jerry Hu
2023-07-10 17:21:23 +08:00
committed by GitHub
parent 842fe00157
commit 36524f2b72
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/vec/functions/function_helpers.cpp
View File

@ -44,6 +44,7 @@ std::tuple<Block, ColumnNumbers> create_block_with_nested_columns(const Block& b
const bool need_check_same) {
Block res;
ColumnNumbers res_args(args.size());
res.reserve(args.size() + 1);
// only build temp block by args column, if args[i] == args[j]
// just keep one
@ -100,7 +101,7 @@ std::tuple<Block, ColumnNumbers> create_block_with_nested_columns(const Block& b
}
}
return {res, res_args};
return {std::move(res), std::move(res_args)};
}
std::tuple<Block, ColumnNumbers, size_t> create_block_with_nested_columns(const Block& block,
@ -109,7 +110,7 @@ std::tuple<Block, ColumnNumbers, size_t> create_block_with_nested_columns(const
auto [res, res_args] = create_block_with_nested_columns(block, args, true);
// insert result column in temp block
res.insert(block.get_by_position(result));
return {res, res_args, res.columns() - 1};
return {std::move(res), std::move(res_args), res.columns() - 1};
}
void validate_argument_type(const IFunction& func, const DataTypes& arguments,