database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Improvement](unset_variable) add docs for unset-variable stmt and update privilege check (#27672)

Browse Source
This commit is contained in:
Yulei-Yang
2023-11-29 10:30:18 +08:00
committed by GitHub
parent 6371dbab33
commit 3bc09e55f6
3 changed files with 173 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fe/fe-core/src/main/java/org/apache/doris/analysis/UnsetVariableStmt.java
View File

@ -17,8 +17,13 @@
package org.apache.doris.analysis;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
import org.apache.doris.common.UserException;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.qe.ConnectContext;
import com.amazonaws.util.StringUtils;
@ -65,6 +70,13 @@ public class UnsetVariableStmt extends StatementBase {
if (StringUtils.isNullOrEmpty(variable) && !applyToAll) {
throw new AnalysisException("You should specific the unset variable.");
}
if (setType == SetType.GLOBAL) {
if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
}
}
}
@Override