database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](nereids)set operation's result type is wrong if decimal overflows (#27870)

Browse Source
This commit is contained in:
starocean999
2023-12-01 18:40:06 +08:00
committed by GitHub
parent c93e5d9e89
commit 3f20cf1456
2 changed files with 36 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java
View File

@ -17,6 +17,7 @@
package org.apache.doris.nereids.trees.plans.logical;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.catalog.Type;
import org.apache.doris.nereids.exceptions.AnalysisException;
import org.apache.doris.nereids.memo.GroupExpression;
@ -251,10 +252,21 @@ public abstract class LogicalSetOperation extends AbstractLogicalPlan implements
}
return new StructType(commonFields.build());
}
return DataType.fromCatalogType(Type.getAssignmentCompatibleType(
left.toCatalogDataType(),
right.toCatalogDataType(),
false,
SessionVariable.getEnableDecimal256()));
boolean enableDecimal256 = SessionVariable.getEnableDecimal256();
Type resultType = Type.getAssignmentCompatibleType(left.toCatalogDataType(),
right.toCatalogDataType(), false, enableDecimal256);
if (resultType.isDecimalV3()) {
int oldPrecision = resultType.getPrecision();
int oldScale = resultType.getDecimalDigits();
int integerPart = oldPrecision - oldScale;
int maxPrecision = enableDecimal256 ? ScalarType.MAX_DECIMAL256_PRECISION
: ScalarType.MAX_DECIMAL128_PRECISION;
if (oldPrecision > maxPrecision) {
int newScale = maxPrecision - integerPart;
resultType =
ScalarType.createDecimalType(maxPrecision, newScale < 0 ? 0 : newScale);
}
}
return DataType.fromCatalogType(resultType);
}
}