database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Add check for to_bitmap function argument (#1747)

Browse Source
This commit is contained in:
kangkaisen
2019-09-05 18:11:38 +08:00
committed by ZHAO Chun
parent 85940a292b
commit 3f22238012
8 changed files with 90 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
be/src/exprs/bitmap_function.cpp
View File

@ -59,12 +59,30 @@ BigIntVal BitmapFunctions::bitmap_count(FunctionContext* ctx, const StringVal& s
return result;
}
// we assume the input src is a valid integer string
StringVal BitmapFunctions::to_bitmap(doris_udf::FunctionContext* ctx, const doris_udf::StringVal& src) {
std::unique_ptr<RoaringBitmap> bitmap {new RoaringBitmap()};
if (!src.is_null) {
std::string tmp_str = std::string(reinterpret_cast<char*>(src.ptr), src.len) ;
bitmap->update(std::stoi(tmp_str));
unsigned long uint32_value = 0;
try {
uint32_value = std::stoul(tmp_str);
// the std::stoul result type is unsigned long, not uint32_t. so we need check it
if(UNLIKELY(uint32_value > std::numeric_limits<unsigned int>::max())) {
throw std::out_of_range("");
}
} catch (std::invalid_argument& e) {
std::stringstream error_msg;
error_msg << "The to_bitmap function argument: " << tmp_str << " type isn't integer family";
ctx->set_error(error_msg.str().c_str());
return StringVal::null();
} catch (std::out_of_range& e) {
std::stringstream error_msg;
error_msg << "The to_bitmap function argument: " << tmp_str << " exceed unsigned integer max value "
<< std::numeric_limits<unsigned int>::max();
ctx->set_error(error_msg.str().c_str());
return StringVal::null();
}
bitmap->update(uint32_value);
}
std::string buf;
buf.resize(bitmap->size());