diff --git a/be/src/exec/csv_scan_node.cpp b/be/src/exec/csv_scan_node.cpp index 847554065a..ab64a5c762 100644 --- a/be/src/exec/csv_scan_node.cpp +++ b/be/src/exec/csv_scan_node.cpp @@ -557,7 +557,6 @@ bool CsvScanNode::split_check_fill(const std::string& line, RuntimeState* state) if (flag == false) { LOG(INFO) << error_msg.str(); - ; return false; } } diff --git a/be/src/exec/parquet_reader.cpp b/be/src/exec/parquet_reader.cpp index ec2f31c2da..ddb3531e17 100644 --- a/be/src/exec/parquet_reader.cpp +++ b/be/src/exec/parquet_reader.cpp @@ -123,7 +123,7 @@ Status ParquetReaderWrap::init_parquet_reader(const std::vector void ParquetReaderWrap::close() { arrow::Status st = _parquet->Close(); if (!st.ok()) { - LOG(WARNING) << "close parquet file error"; + LOG(WARNING) << "close parquet file error: " << st.ToString(); } } @@ -542,7 +542,7 @@ ParquetFile::ParquetFile(FileReader* file) : _file(file) {} ParquetFile::~ParquetFile() { arrow::Status st = Close(); if (!st.ok()) { - LOG(WARNING) << "close parquet file error"; + LOG(WARNING) << "close parquet file error: " << st.ToString(); } } diff --git a/be/src/exec/parquet_writer.cpp b/be/src/exec/parquet_writer.cpp index f45060b0b3..b1bb3aedf4 100644 --- a/be/src/exec/parquet_writer.cpp +++ b/be/src/exec/parquet_writer.cpp @@ -44,7 +44,7 @@ ParquetOutputStream::ParquetOutputStream(FileWriter* file_writer) ParquetOutputStream::~ParquetOutputStream() { arrow::Status st = Close(); if (!st.ok()) { - LOG(WARNING) << "close parquet file error"; + LOG(WARNING) << "close parquet file error: " << st.ToString(); } } @@ -468,7 +468,7 @@ void ParquetWriterWrapper::close() { _writer->Close(); arrow::Status st = _outstream->Close(); if (!st.ok()) { - LOG(WARNING) << "close parquet file error"; + LOG(WARNING) << "close parquet file error: " << st.ToString(); } } catch (const std::exception& e) { _rg_writer = nullptr; diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp b/be/src/olap/rowset/segment_v2/segment_iterator.cpp index 2754aefe6d..8b32e6d79a 100644 --- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp +++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp @@ -592,8 +592,8 @@ Status SegmentIterator::next_batch(RowBlockV2* block) { void SegmentIterator::_vec_init_lazy_materialization() { _is_pred_column.resize(_schema.columns().size(), false); - std::set - pred_column_ids; // including short_cir_pred_col_id_set and vec_pred_col_id_set + // including short_cir_pred_col_id_set and vec_pred_col_id_set + std::set pred_column_ids; _is_all_column_basic_type = true; bool is_predicate_column_exists = false; bool is_non_predicate_column_exists = false; diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp index ce74604985..c2e500b193 100644 --- a/be/src/runtime/exec_env_init.cpp +++ b/be/src/runtime/exec_env_init.cpp @@ -101,16 +101,16 @@ Status ExecEnv::_init(const std::vector& store_paths) { new ExtDataSourceServiceClientCache(config::max_client_cache_size_per_host); _pool_mem_trackers = new PoolMemTrackerRegistry(); _thread_mgr = new ThreadResourceMgr(); - if (config::doris_enable_scanner_thread_pool_per_disk - && config::doris_scanner_thread_pool_thread_num >= store_paths.size() - && store_paths.size() > 0) { - _scan_thread_pool = new PriorityWorkStealingThreadPool(config::doris_scanner_thread_pool_thread_num, - store_paths.size(), - config::doris_scanner_thread_pool_queue_size); + if (config::doris_enable_scanner_thread_pool_per_disk && + config::doris_scanner_thread_pool_thread_num >= store_paths.size() && + store_paths.size() > 0) { + _scan_thread_pool = new PriorityWorkStealingThreadPool( + config::doris_scanner_thread_pool_thread_num, store_paths.size(), + config::doris_scanner_thread_pool_queue_size); LOG(INFO) << "scan thread pool use PriorityWorkStealingThreadPool"; } else { _scan_thread_pool = new PriorityThreadPool(config::doris_scanner_thread_pool_thread_num, - config::doris_scanner_thread_pool_queue_size); + config::doris_scanner_thread_pool_queue_size); LOG(INFO) << "scan thread pool use PriorityThreadPool"; } @@ -136,7 +136,8 @@ Status ExecEnv::_init(const std::vector& store_paths) { _etl_job_mgr = new EtlJobMgr(this); _load_path_mgr = new LoadPathMgr(this); _disk_io_mgr = new DiskIoMgr(); - _tmp_file_mgr = new TmpFileMgr(this), _bfd_parser = BfdParser::create(); + _tmp_file_mgr = new TmpFileMgr(this); + _bfd_parser = BfdParser::create(); _broker_mgr = new BrokerMgr(this); _load_channel_mgr = new LoadChannelMgr(); _load_stream_mgr = new LoadStreamMgr();