database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Optimization](functions)Optimize function call for const columns. (#18310)

Browse Source
This commit is contained in:
zclllyybb
2023-04-12 11:11:01 +08:00
committed by GitHub
parent 49a9956986
commit 43392918cd
25 changed files with 1718 additions and 849 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
be/src/vec/functions/function.cpp
View File

@ -70,7 +70,7 @@ ColumnPtr wrap_in_nullable(const ColumnPtr& src, const Block& block, const Colum
} else {
if (!mutable_result_null_map_column) {
mutable_result_null_map_column =
(*std::move(result_null_map_column)).assume_mutable();
std::move(result_null_map_column)->assume_mutable();
}
NullMap& result_null_map =
@ -166,15 +166,24 @@ Status PreparedFunctionImpl::default_implementation_for_constant_arguments(
!all_arguments_are_constant(block, args)) {
return Status::OK();
}
// now all columns is const.
Block temporary_block;
size_t arguments_size = args.size();
for (size_t arg_num = 0; arg_num < arguments_size; ++arg_num) {
const ColumnWithTypeAndName& column = block.get_by_position(args[arg_num]);
temporary_block.insert(
{assert_cast<const ColumnConst*>(column.column.get())->get_data_column_ptr(),
column.type, column.name});
// Columns in const_list --> column_const, others --> nested_column
// that's because some functions supposes some specific columns always constant.
// If we unpack it, there will be unnecessary cost of virtual judge.
if (args_expect_const.end() !=
std::find(args_expect_const.begin(), args_expect_const.end(), arg_num)) {
temporary_block.insert({column.column, column.type, column.name});
} else {
temporary_block.insert(
{assert_cast<const ColumnConst*>(column.column.get())->get_data_column_ptr(),
column.type, column.name});
}
}
temporary_block.insert(block.get_by_position(result));