database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor](conjuncts) simplify conjuncts in exec node (#19254)

Browse Source 
Co-authored-by: yiguolei <yiguolei@gmail.com>
Currently, exec node save exprcontext**, but the object is in object pool, the code is very unclear. we could just use exprcontext*.
This commit is contained in:
yiguolei
2023-05-04 18:04:32 +08:00
committed by GitHub
parent fa7d86efbd
commit 4e4fb33995
29 changed files with 84 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
be/src/vec/exec/vaggregation_node.cpp
View File

@ -473,9 +473,9 @@ Status AggregationNode::prepare_profile(RuntimeState* state) {
std::bind<void>(&AggregationNode::_update_memusage_with_serialized_key, this);
_executor.close = std::bind<void>(&AggregationNode::_close_with_serialized_key, this);
_should_limit_output = _limit != -1 && // has limit
!_vconjunct_ctx_ptr && // no having conjunct
_needs_finalize; // agg's finalize step
_should_limit_output = _limit != -1 && // has limit
_vconjunct_ctx_ptr == nullptr && // no having conjunct
_needs_finalize; // agg's finalize step
}
return Status::OK();