database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[branch-2.1](nereids) remove interface Nondeterministic and fix random/random_bytes foldable properties (#39944) (#40650)

Browse Source 
pick https://github.com/apache/doris/pull/39944
This commit is contained in:
zclllhhjj
2024-09-11 17:27:52 +08:00
committed by GitHub
parent 8708fae420
commit 52e13c9e6c
3 changed files with 16 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Nondeterministic.java
View File

@ -1,34 +0,0 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package org.apache.doris.nereids.trees.expressions.functions;
/**
* Nondeterministic functions.
* <p>
* e.g. 'rand()', 'random()'.
*/
public interface Nondeterministic extends ExpressionTrait {
/**
* Identify the function is deterministic or not, such as UnixTimestamp, when it's children is not empty
* it's deterministic
*/
default boolean isDeterministic() {
return false;
}
}

5
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Random.java
View File

@ -118,4 +118,9 @@ public class Random extends ScalarFunction
public boolean isDeterministic() {
return false;
}
@Override
public boolean foldable() {
return false;
}
}

13
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/RandomBytes.java
View File

@ -20,7 +20,6 @@ package org.apache.doris.nereids.trees.expressions.functions.scalar;
import org.apache.doris.catalog.FunctionSignature;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.functions.Nondeterministic;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import org.apache.doris.nereids.types.IntegerType;
@ -36,7 +35,7 @@ import java.util.List;
* ScalarFunction 'random_bytes'. This class is generated by GenerateFunction.
*/
public class RandomBytes extends ScalarFunction
implements ExplicitlyCastableSignature, PropagateNullable, Nondeterministic {
implements ExplicitlyCastableSignature, PropagateNullable {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(StringType.INSTANCE).args(IntegerType.INSTANCE),
@ -60,6 +59,16 @@ public class RandomBytes extends ScalarFunction
return new RandomBytes(children.get(0));
}
@Override
public boolean isDeterministic() {
return false;
}
@Override
public boolean foldable() {
return false;
}
@Override
public List<FunctionSignature> getSignatures() {
return SIGNATURES;