From 5678708b7dd9c6d12aa34abd4546e4ad003a2b02 Mon Sep 17 00:00:00 2001
From: LiBinfeng <46676950+Bingandbing@users.noreply.github.com>
Date: Fri, 7 Apr 2023 17:38:08 +0800
Subject: [PATCH] [Fix](nereids) change setting byte size from translator to
 catalog generate scalar type (#18450)

Problem: when used nereids to generate scalarType, byteSize would be set. After switch the optimizer to planner, planner would reuse scalarType in some cases.
Fix: change byteSize setting from Plan translator to toCatalogDataType
---
 .../doris/nereids/glue/translator/ExpressionTranslator.java | 6 +-----
 .../java/org/apache/doris/nereids/types/VarcharType.java    | 4 +++-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java
index e36e30f0b6..4ab6d4e30e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java
@@ -107,11 +107,7 @@ public class ExpressionTranslator extends DefaultExpressionVisitor<Expr, PlanTra
      * @return stale planner's expr
      */
     public static Expr translate(Expression expression, PlanTranslatorContext context) {
-        Expr staleExpr = expression.accept(INSTANCE, context);
-        if (staleExpr.getType() instanceof ScalarType) {
-            ((ScalarType) staleExpr.getType()).setByteSize(expression.getDataType().width());
-        }
-        return staleExpr;
+        return expression.accept(INSTANCE, context);
     }
 
     @Override
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/types/VarcharType.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/types/VarcharType.java
index 305daff8bf..5f7d7708c2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/types/VarcharType.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/types/VarcharType.java
@@ -49,7 +49,9 @@ public class VarcharType extends CharacterType {
 
     @Override
     public Type toCatalogDataType() {
-        return ScalarType.createVarcharType(len);
+        ScalarType catalogDataType = ScalarType.createVarcharType(len);
+        catalogDataType.setByteSize(len);
+        return catalogDataType;
     }
 
     @Override