database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor](exceptionsafe) disallow call new method explicitly (#18830)

Browse Source 
disallow call new method explicitly
force to use create_shared or create_unique to use shared ptr
placement new is allowed
reference https://abseil.io/tips/42 to add factory method to all class.
I think we should follow this guide because if throw exception in new method, the program will terminate.

---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
This commit is contained in:
yiguolei
2023-04-21 09:13:24 +08:00
committed by GitHub
parent 5a0c1cb1b9
commit 63a76ed115
22 changed files with 98 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
be/test/vec/function/function_test_util.cpp
View File

@ -290,7 +290,7 @@ Block* create_block_from_inputset(const InputTypeSet& input_types, const InputDa
// 1.1 insert data and create block
auto row_size = input_set.size();
std::unique_ptr<Block> block(new Block());
std::unique_ptr<Block> block = Block::create_unique();
for (size_t i = 0; i < descs.size(); ++i) {
auto& desc = descs[i];
auto column = desc.data_type->create_column();
@ -357,7 +357,7 @@ Block* process_table_function(TableFunction* fn, Block* input_block,
} while (!fn->eos());
}
std::unique_ptr<Block> output_block(new Block());
std::unique_ptr<Block> output_block = Block::create_unique();
output_block->insert({std::move(column), descs[0].data_type, descs[0].col_name});
return output_block.release();
}