database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Fix](Status) Make Status [[nodiscard]] and handle returned Status correctly (#23395)

Browse Source
This commit is contained in:
bobhan1
2023-09-29 22:38:52 +08:00
committed by GitHub
parent 8040ba7fb9
commit 642e5cdb69
301 changed files with 2251 additions and 2009 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
be/src/vec/functions/function_rpc.cpp
View File

@ -73,7 +73,7 @@ void RPCFnImpl::_convert_block_to_proto(Block& block, const ColumnNumbers& argum
ColumnWithTypeAndName& column = block.get_by_position(col_idx);
arg->set_has_null(column.column->has_null(row_count));
auto col = column.column->convert_to_full_column_if_const();
column.type->get_serde()->write_column_to_pb(*col, *arg, 0, row_count);
static_cast<void>(column.type->get_serde()->write_column_to_pb(*col, *arg, 0, row_count));
}
}
@ -81,7 +81,7 @@ void RPCFnImpl::_convert_to_block(Block& block, const PValues& result, size_t po
auto data_type = block.get_data_type(pos);
auto col = data_type->create_column();
auto serde = data_type->get_serde();
serde->read_column_from_pb(*col, result);
static_cast<void>(serde->read_column_from_pb(*col, result));
block.replace_by_position(pos, std::move(col));
}