From 6430ff365dbb86e634e2aefe07584c8a6fc0fbb2 Mon Sep 17 00:00:00 2001 From: zhangstar333 Date: Tue, 18 Mar 2025 18:03:29 +0800 Subject: [PATCH] [Bug](partition) should not do reset for the partition_sorts (#49148) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### What problem does this PR solve? Problem Summary: the partition_sorts is unique_ptr，could release after destroy. and when some extreme case like cancel, if source reset the sorter early, the sink operator will coredump still use it. --- be/src/pipeline/exec/partition_sort_source_operator.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/be/src/pipeline/exec/partition_sort_source_operator.cpp b/be/src/pipeline/exec/partition_sort_source_operator.cpp index 7c89b6ba42..b6c5327144 100644 --- a/be/src/pipeline/exec/partition_sort_source_operator.cpp +++ b/be/src/pipeline/exec/partition_sort_source_operator.cpp @@ -104,7 +104,6 @@ Status PartitionSortSourceOperatorX::get_sorted_block(RuntimeState* state, } if (current_eos) { // current sort have eos, so get next idx - local_state._shared_state->partition_sorts[local_state._sort_idx].reset(nullptr); local_state._sort_idx++; }