From 6a6be52bc9272bbfb1bbff46f919da333dd2f27a Mon Sep 17 00:00:00 2001 From: Xin Liao Date: Thu, 18 May 2023 08:41:49 +0800 Subject: [PATCH] [enhancement](merge-on-write) Avoiding unnecessary primary key index traversal (#19746) --- be/src/olap/tablet.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp index 4ad0c64b66..680686d850 100644 --- a/be/src/olap/tablet.cpp +++ b/be/src/olap/tablet.cpp @@ -3004,8 +3004,10 @@ Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const TabletT delete_bitmap->remove({to_del, 0, 0}, {to_del, UINT32_MAX, INT64_MAX}); } - RETURN_IF_ERROR(calc_delete_bitmap(rowset, segments, &rowset_ids_to_add, delete_bitmap, - cur_version - 1, false, rowset_writer)); + if (!rowset_ids_to_add.empty()) { + RETURN_IF_ERROR(calc_delete_bitmap(rowset, segments, &rowset_ids_to_add, delete_bitmap, + cur_version - 1, false, rowset_writer)); + } // update version without write lock, compaction and publish_txn // will update delete bitmap, handle compaction with _rowset_update_lock