From 7134da63ac7dda26410dd735e1fd59a70be32535 Mon Sep 17 00:00:00 2001 From: xueweizhang Date: Sat, 25 Nov 2023 10:37:23 +0800 Subject: [PATCH] [improvement](nereids) add config for nereids trace dir (#27495) Signed-off-by: nextdreamblue --- docs/en/docs/admin-manual/config/fe-config.md | 6 ++++++ docs/zh-CN/docs/admin-manual/config/fe-config.md | 6 ++++++ .../src/main/java/org/apache/doris/common/Config.java | 4 ++++ .../org/apache/doris/nereids/minidump/NereidsTracer.java | 3 ++- 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/docs/en/docs/admin-manual/config/fe-config.md b/docs/en/docs/admin-manual/config/fe-config.md index 772dc25b64..047bc3aba4 100644 --- a/docs/en/docs/admin-manual/config/fe-config.md +++ b/docs/en/docs/admin-manual/config/fe-config.md @@ -1728,6 +1728,12 @@ Default: false If true, will compress fe.audit.log by gzip +#### `nereids_trace_log_dir` + +Default: DorisFE.DORIS_HOME_DIR + "/log/nereids_trace" + +Used to specify the directory of the nereids trace log + ### Storage #### `min_replication_num_per_tablet` diff --git a/docs/zh-CN/docs/admin-manual/config/fe-config.md b/docs/zh-CN/docs/admin-manual/config/fe-config.md index bf533b21bf..3a4e878635 100644 --- a/docs/zh-CN/docs/admin-manual/config/fe-config.md +++ b/docs/zh-CN/docs/admin-manual/config/fe-config.md @@ -1728,6 +1728,12 @@ HOUR: log前缀是:yyyyMMddHH 控制是否压缩 fe.audit.log。如果开启,则使用gzip算法进行压缩。 +#### `nereids_trace_log_dir` + +默认值:DorisFE.DORIS_HOME_DIR + "/log/nereids_trace" + +用于存储 nereids trace 日志的目录 + ### 存储 #### `min_replication_num_per_tablet` diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java index e03dfd2a86..b615e41468 100644 --- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java +++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java @@ -2268,4 +2268,8 @@ public class Config extends ConfigBase { + "If it is less than this value, it will be diagnosed as balanced." }) public static double diagnose_balance_max_tablet_num_ratio = 1.1; + + @ConfField(description = {"nereids trace文件的存放路径。", + "The path of the nereids trace file."}) + public static String nereids_trace_log_dir = System.getenv("DORIS_HOME") + "/log/nereids_trace"; } diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/minidump/NereidsTracer.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/minidump/NereidsTracer.java index 2065bd58e9..b28ff8d764 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/minidump/NereidsTracer.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/minidump/NereidsTracer.java @@ -17,6 +17,7 @@ package org.apache.doris.nereids.minidump; +import org.apache.doris.common.Config; import org.apache.doris.common.util.DebugUtil; import org.apache.doris.common.util.TimeUtils; import org.apache.doris.nereids.cost.Cost; @@ -172,7 +173,7 @@ public class NereidsTracer { public static void init() { NereidsTracer.shouldLog = true; startTime = TimeUtils.getStartTimeMs(); - TRACE_PATH = Optional.ofNullable(TRACE_PATH).orElse(System.getenv("DORIS_HOME") + "/log/nereids_trace"); + TRACE_PATH = Optional.ofNullable(TRACE_PATH).orElse(Config.nereids_trace_log_dir); new File(TRACE_PATH).mkdirs(); } }