From 7180cf3d9bcaca2710757cde01047ffaedf204db Mon Sep 17 00:00:00 2001
From: lihangyu <15605149486@163.com>
Date: Tue, 14 Mar 2023 22:13:41 +0800
Subject: [PATCH] [Improve](row store) avoid serialize null slot into a jsonb
 row (#17734)

This could save some disk space
---
 be/src/vec/jsonb/serialize.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/be/src/vec/jsonb/serialize.cpp b/be/src/vec/jsonb/serialize.cpp
index 8a25a64424..6739ada85b 100644
--- a/be/src/vec/jsonb/serialize.cpp
+++ b/be/src/vec/jsonb/serialize.cpp
@@ -157,11 +157,11 @@ static void deserialize_column(PrimitiveType type, JsonbValue* slot_value, Mutab
 static void serialize_column(Arena* mem_pool, const TabletColumn& tablet_column,
                              const IColumn* column, const StringRef& data_ref, int row,
                              JsonbWriterT<JsonbOutStream>& jsonb_writer) {
-    jsonb_writer.writeKey(tablet_column.unique_id());
     if (is_column_null_at(row, column, tablet_column.type(), data_ref)) {
-        jsonb_writer.writeNull();
+        // Do nothing
         return;
     }
+    jsonb_writer.writeKey(tablet_column.unique_id());
     if (tablet_column.is_array_type()) {
         const char* begin = nullptr;
         StringRef value = column->serialize_value_into_arena(row, *mem_pool, begin);