database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor](scanner) use weak ptr to lock task execution context to avoid core in scanner dctor (#28493)

Browse Source 
using weak ptr as a lock between fragment execute thread and scanner thread, to solve the core problem in scanner's dctor to access scannode's profile.
This commit is contained in:
yiguolei
2023-12-18 14:09:32 +08:00
committed by GitHub
parent 4bcde57775
commit 73f7b61019
23 changed files with 241 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/vec/exec/scan/vscan_node.cpp
View File

@ -197,8 +197,7 @@ Status VScanNode::alloc_resource(RuntimeState* state) {
if (_scanner_ctx) {
DCHECK(!_eos && _num_scanners->value() > 0);
RETURN_IF_ERROR(_scanner_ctx->init());
RETURN_IF_ERROR(
_state->exec_env()->scanner_scheduler()->submit(_scanner_ctx.get()));
RETURN_IF_ERROR(_state->exec_env()->scanner_scheduler()->submit(_scanner_ctx));
}
if (_shared_scan_opt) {
_shared_scanner_controller->set_scanner_context(id(),
@ -218,7 +217,7 @@ Status VScanNode::alloc_resource(RuntimeState* state) {
: Status::OK());
if (_scanner_ctx) {
RETURN_IF_ERROR(_scanner_ctx->init());
RETURN_IF_ERROR(_state->exec_env()->scanner_scheduler()->submit(_scanner_ctx.get()));
RETURN_IF_ERROR(_state->exec_env()->scanner_scheduler()->submit(_scanner_ctx));
}
}