database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Optimize] Remove some unused code to reduce lock contention (#6566)

Browse Source 
1. Remove global runtime profile counter
2. Remove unused thread token register
This commit is contained in:
Mingyu Chen
2021-09-07 11:56:12 +08:00
committed by GitHub
parent 577ff01094
commit 74ddea8d83
11 changed files with 10 additions and 356 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
be/src/exec/blocking_join_node.cpp
View File

@ -82,10 +82,6 @@ Status BlockingJoinNode::close(RuntimeState* state) {
void BlockingJoinNode::build_side_thread(RuntimeState* state, boost::promise<Status>* status) {
status->set_value(construct_build_side(state));
// Release the thread token as soon as possible (before the main thread joins
// on it). This way, if we had a chain of 10 joins using 1 additional thread,
// we'd keep the additional thread busy the whole time.
state->resource_pool()->release_thread_token(false);
}
Status BlockingJoinNode::open(RuntimeState* state) {
@ -105,19 +101,8 @@ Status BlockingJoinNode::open(RuntimeState* state) {
// main thread
boost::promise<Status> build_side_status;
if (state->resource_pool()->try_acquire_thread_token()) {
add_runtime_exec_option("Join Build-Side Prepared Asynchronously");
// Thread build_thread(_node_name, "build thread",
// bind(&BlockingJoinNode::BuildSideThread, this, state, &build_side_status));
// if (!state->cgroup().empty()) {
// RETURN_IF_ERROR(
// state->exec_env()->cgroups_mgr()->assign_thread_to_cgroup(
// build_thread, state->cgroup()));
// }
boost::thread(bind(&BlockingJoinNode::build_side_thread, this, state, &build_side_status));
} else {
build_side_status.set_value(construct_build_side(state));
}
add_runtime_exec_option("Join Build-Side Prepared Asynchronously");
boost::thread(bind(&BlockingJoinNode::build_side_thread, this, state, &build_side_status));
// Open the left child so that it may perform any initialisation in parallel.
// Don't exit even if we see an error, we still need to wait for the build thread