database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Enhancement](function) optimize for decimal arithmetic calculation (#14674)

Browse Source 
* optimize for decimal arithmetic calculation

* Apply suggestions from code review

Co-authored-by: Gabriel <gabrielleebuaa@gmail.com>

Co-authored-by: Gabriel <gabrielleebuaa@gmail.com>
This commit is contained in:
Pxl
2022-11-30 10:41:03 +08:00
committed by GitHub
parent ca90253b09
commit 7a1fde379c
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
be/src/vec/functions/function_binary_arithmetic.h
View File

@ -295,12 +295,15 @@ struct DecimalBinaryOperation {
for (size_t i = 0; i < size; ++i) {
c[i] = apply_scaled_div(a, b[i]);
}
return;
}
/// default: use it if no return before
for (size_t i = 0; i < size; ++i) {
c[i] = apply(a, b[i]);
} else if constexpr (IsDecimalV2<A> || IsDecimalV2<B>) {
DecimalV2Value da(a);
for (size_t i = 0; i < size; ++i) {
c[i] = Op::template apply(da, DecimalV2Value(b[i])).value();
}
} else {
for (size_t i = 0; i < size; ++i) {
c[i] = apply(a, b[i]);
}
}
}
@ -413,12 +416,7 @@ private:
if constexpr (IsDecimalV2<B> || IsDecimalV2<A>) {
// Now, Doris only support decimal +-*/ decimal.
// overflow in consider in operator
DecimalV2Value l(a);
DecimalV2Value r(b);
auto ans = Op::template apply(l, r);
NativeResultType result;
memcpy(&result, &ans, sizeof(NativeResultType));
return result;
return Op::template apply(DecimalV2Value(a), DecimalV2Value(b)).value();
} else {
if constexpr (OpTraits::can_overflow && check_overflow) {
NativeResultType res;