From 7cf1ffa0b47ef713a78871fa0a7fc718095eeaef Mon Sep 17 00:00:00 2001 From: AKIRA <33112463+Kikyou1997@users.noreply.github.com> Date: Thu, 27 Apr 2023 21:09:11 +0900 Subject: [PATCH] [fix](planner) ctas should not clone queryStmt after parse (#19114) Remove redundant clone in the constructor of CTAS stmt Error message: ``` NullPointerException, msg: java.lang.NullPointerException: null ``` --- .../org/apache/doris/analysis/CreateTableAsSelectStmt.java | 2 +- .../java/org/apache/doris/analysis/FunctionCallExpr.java | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java index 284b861716..45bdb4bdbb 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java @@ -51,7 +51,7 @@ public class CreateTableAsSelectStmt extends DdlStmt { this.createTableStmt = createTableStmt; this.columnNames = columnNames; this.queryStmt = queryStmt; - this.insertStmt = new InsertStmt(createTableStmt.getDbTbl(), queryStmt.clone()); + this.insertStmt = new InsertStmt(createTableStmt.getDbTbl(), queryStmt); } /** diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java index 6908b64fae..7de72ee33c 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java @@ -1655,11 +1655,6 @@ public class FunctionCallExpr extends Expr { } // rewrite return type if is nested type function analyzeNestedFunction(); - for (OrderByElement o : orderByElements) { - if (!o.getExpr().isAnalyzed) { - o.getExpr().analyzeImpl(analyzer); - } - } } // if return type is nested type, need to be determined the sub-element type