database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug] Double/Float % 0 should be NULL (#8230)

Browse Source 
Co-authored-by: lihaopeng <lihaopeng@baidu.com>
This commit is contained in:
HappenLee
2022-02-25 11:03:42 +08:00
committed by GitHub
parent 4c5d7c27df
commit 8642fa38b9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
be/src/exprs/arithmetic_expr.cpp
View File

@ -113,7 +113,7 @@ FloatVal ModExpr::get_float_val(ExprContext* context, TupleRow* row) {
return FloatVal::null();
}
FloatVal v2 = _children[1]->get_float_val(context, row);
if (v2.is_null) {
if (v2.is_null || v2.val == 0) {
return FloatVal::null();
}
return FloatVal(fmod(v1.val, v2.val));
@ -125,7 +125,7 @@ DoubleVal ModExpr::get_double_val(ExprContext* context, TupleRow* row) {
return DoubleVal::null();
}
DoubleVal v2 = _children[1]->get_double_val(context, row);
if (v2.is_null) {
if (v2.is_null || v2.val == 0) {
return DoubleVal::null();
}
return DoubleVal(fmod(v1.val, v2.val));