From 886aabda31d019e57f725ab1ee930b85e6fecfbb Mon Sep 17 00:00:00 2001 From: wangbo Date: Thu, 21 Mar 2024 13:56:04 +0800 Subject: [PATCH] [Fix](executor) Fix insert select not close coordinator #32571 --- .../trees/plans/commands/insert/AbstractInsertExecutor.java | 1 + .../src/main/java/org/apache/doris/qe/Coordinator.java | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java index 1a9ce2d744..922dae6d40 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java @@ -172,6 +172,7 @@ public abstract class AbstractInsertExecutor { onFail(t); return; } finally { + coordinator.close(); executor.updateProfile(true); QeProcessorImpl.INSTANCE.unregisterQuery(ctx.queryId()); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java index 3d4e8cb75f..9da938ee74 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java @@ -634,7 +634,11 @@ public class Coordinator implements CoordInterface { @Override public void close() { if (queryQueue != null && queueToken != null) { - queryQueue.returnToken(queueToken); + try { + queryQueue.returnToken(queueToken); + } catch (Throwable t) { + LOG.error("error happens when coordinator close ", t); + } } }