From 8b45258ae6e2eee3792bc67d925ee5634a892fb6 Mon Sep 17 00:00:00 2001 From: wuwenchi Date: Sat, 4 Jan 2025 09:01:14 +0800 Subject: [PATCH] [fix](external)using saved member variables for 2.1 (#46156) (#46400) bp: #46156 --- .../org/apache/doris/datasource/FileQueryScanNode.java | 9 ++++----- .../doris/datasource/hive/source/HiveScanNode.java | 2 +- .../doris/datasource/hudi/source/HudiScanNode.java | 3 +-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java index 9cb45d3a2d..457ee88fec 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java +++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java @@ -337,7 +337,7 @@ public abstract class FileQueryScanNode extends FileScanNode { FileSplit fileSplit = (FileSplit) splitAssignment.getSampleSplit(); TFileType locationType = fileSplit.getLocationType(); totalFileSize = fileSplit.getLength() * selectedSplitNum; - long maxWaitTime = ConnectContext.get().getSessionVariable().getFetchSplitsMaxWaitTime(); + long maxWaitTime = sessionVariable.getFetchSplitsMaxWaitTime(); // Not accurate, only used to estimate concurrency. // Here, we must take the max of 1, because // in the case of multiple BEs, `numApproximateSplits() / backendPolicy.numBackends()` may be 0, @@ -560,10 +560,9 @@ public abstract class FileQueryScanNode extends FileScanNode { @Override public int getNumInstances() { - if (ConnectContext.get() != null - && ConnectContext.get().getSessionVariable().getEnablePipelineXEngine() - && ConnectContext.get().getSessionVariable().isIgnoreStorageDataDistribution()) { - return ConnectContext.get().getSessionVariable().getParallelExecInstanceNum(); + if (sessionVariable.getEnablePipelineXEngine() + && sessionVariable.isIgnoreStorageDataDistribution()) { + return sessionVariable.getParallelExecInstanceNum(); } return scanRangeLocations.size(); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java index dcabd11358..3780a80faa 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java +++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java @@ -254,7 +254,7 @@ public class HiveScanNode extends FileQueryScanNode { } partitionInit = true; } - int numPartitions = ConnectContext.get().getSessionVariable().getNumPartitionsInBatchMode(); + int numPartitions = sessionVariable.getNumPartitionsInBatchMode(); return numPartitions >= 0 && prunedPartitions.size() >= numPartitions; } diff --git a/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java b/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java index 5962cd7b26..a6156924e2 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java +++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java @@ -38,7 +38,6 @@ import org.apache.doris.datasource.hive.HivePartition; import org.apache.doris.datasource.hive.source.HiveScanNode; import org.apache.doris.datasource.hudi.HudiSchemaCacheValue; import org.apache.doris.planner.PlanNodeId; -import org.apache.doris.qe.ConnectContext; import org.apache.doris.qe.SessionVariable; import org.apache.doris.spi.Split; import org.apache.doris.statistics.StatisticalType; @@ -448,7 +447,7 @@ public class HudiScanNode extends HiveScanNode { } partitionInit = true; } - int numPartitions = ConnectContext.get().getSessionVariable().getNumPartitionsInBatchMode(); + int numPartitions = sessionVariable.getNumPartitionsInBatchMode(); return numPartitions >= 0 && prunedPartitions.size() >= numPartitions; }