From 8d6561b32d8457dacf65e7eaf21986ffd9397230 Mon Sep 17 00:00:00 2001
From: zy-kkk <zhongyk10@gmail.com>
Date: Thu, 21 Mar 2024 16:34:45 +0800
Subject: [PATCH] [opt](jdbc catalog) set jdbc test_connection default true
 (#32546)

---
 .../apache/doris/datasource/jdbc/JdbcExternalCatalog.java | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java b/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
index 4892a56ca5..db98df8bc9 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
@@ -22,6 +22,7 @@ import org.apache.doris.catalog.JdbcResource;
 import org.apache.doris.catalog.JdbcTable;
 import org.apache.doris.catalog.TableIf.TableType;
 import org.apache.doris.common.DdlException;
+import org.apache.doris.common.FeConstants;
 import org.apache.doris.datasource.CatalogMgr;
 import org.apache.doris.datasource.CatalogProperty;
 import org.apache.doris.datasource.ExternalCatalog;
@@ -213,7 +214,8 @@ public class JdbcExternalCatalog extends ExternalCatalog {
     }
 
     public boolean isTestConnection() {
-        return Boolean.parseBoolean(catalogProperty.getOrDefault(JdbcResource.TEST_CONNECTION, "false"));
+        return Boolean.parseBoolean(catalogProperty.getOrDefault(JdbcResource.TEST_CONNECTION, JdbcResource
+                .getDefaultPropertyValue(JdbcResource.TEST_CONNECTION)));
     }
 
     @Override
@@ -296,6 +298,10 @@ public class JdbcExternalCatalog extends ExternalCatalog {
     }
 
     private void testJdbcConnection(boolean isReplay) throws DdlException {
+        if (FeConstants.runningUnitTest) {
+            // skip test connection in unit test
+            return;
+        }
         if (!isReplay) {
             if (isTestConnection()) {
                 try {